Repository navigation
フリーフリックキーに方向ガイドを表示 / Show directional guides on Free Flick keys - #1370
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
日本語
Issue の項目2に対応します。 Issue #1360
フリーフリックキーが既存のガイド描画処理を通っていませんでした。「フリックガイドの表示」がオンのとき、開始マップの文字とマップ切替のラベルをキーに表示します。同じ方向に複数の候補がある場合は、キーに最も近い候補を表示します。カスタムキーの中央ラベルを保ち、ガイドには既存の文字サイズと文字数設定を適用します。
確認
関連する Gradle テスト15件が通過しました。ガイド設定のオン・オフ、切替ラベル、斜め方向の文字、絵文字を含む文字数制限を確認しました。
English
Addresses item 2 of the Free Flick issue. Issue #1360
Free Flick keys skipped the on-key guide rendering path. With Show flick guides enabled, they now display the start map's text and map-switch labels. When multiple regions share a direction, the closest region supplies the label. The guide uses the existing text size and character limit settings and preserves the custom key's center label.
Verification
All 15 targeted Gradle tests passed. The regression test covers the guide toggle, switch labels, diagonal text, and character limits for labels that contain emoji.