Repository navigation
fix(desktop-ui): theme accessors, web save bar, and U focus shortcut - #4593
Closed
tyler-dane wants to merge 1 commit into
Closed
tyler-dane wants to merge 1 commit into
tyler-dane wants to merge 1 commit into
Conversation
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
tyler-dane
marked this pull request as ready for review
October 19, 2026 15:12
tyler-dane
added
the
agent-automerge
tyler-dane
enabled auto-merge
October 19, 2026 15:12
This was referenced Oct 19, 2026
Contributor
Author
|
Superseded by #4603 (native theme tokens, save bar, focus-event, FormCard dates). |
github-merge-queue
Bot
removed this pull request from the merge queue due to a manual request
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4331
What and why
First parity fixes from desktop-web-parity-checklist.md (see checklist PR #4592):
NativeWebThemeso SwiftUI stops inverting unrelated surfaces.c-button-save-bar: accent fill, on-accent label, space-between layout, ⌘Enter keycap hint (EventFormView).focus-event(u) to seed grid focus like webonFocusCalendar.nativeWebFocusRingmodifier for future surface work.Verify
Checks:
bun run verify --strict(macOSswift testruns on GitHubtest-macos.yml).Screenshots
Web reference save bar:
SaveSection.tsx/c-button-save-bar. macOS matches accent/on-accent layout inEventFormView.swift(CI snapshot follow-up on macOS runners).