Repository navigation
feat(macos): lowercase day-prefix week event jump chips - #4697
Closed
tyler-dane wants to merge 9 commits into
Closed
tyler-dane wants to merge 9 commits into
tyler-dane wants to merge 9 commits into
Conversation
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
tyler-dane
marked this pull request as ready for review
October 21, 2026 19:00
tyler-dane
enabled auto-merge
October 21, 2026 19:00
tyler-dane
added
the
agent-automerge
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
tyler-dane
disabled auto-merge
October 22, 2026 02:05
Contributor
Author
|
agent-loop: still conflicting after update-branch onto main. Closing so the issue can be relaunched. |
tyler-dane
removed
the
agent-automerge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Native week grid event jump chips now use the same lowercase day-prefix scheme as web (
su1,f4,sa2, …).buildEventJumpHintsassigns labels via sharedDayJumpKeyAssignmentlogic, keyboard input accepts the same sequences (including weekendsthenu/a), barefwhile jump mode is active selects Friday instead of toggling jump off, and quick-time digits still apply when no day-prefix buffer is active.Follow-up to web jump-key work in #4689 for Tyler’s Mac/web parity requirement.
Verify
Swift unit and XCUITest coverage:
DayJumpKeyAssignmentTests, extendedNativeCalendarRootModelEventJumpTests,EventJumpDayPrefixUITests. Full macOS build runs in CI (test-macos.yml).