Repository navigation
fix(macos): open the event form time list on the selected time like web - #4721
Merged
Merged
Conversation
The quarter-hour list always opened at 12 AM, so picking a time near the current one meant scrolling through the morning. Web centers the list on the selected time. Scroll to the selected row, or the quarter hour before it, when the list opens. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GKHjv2HDx1DFAnG4cfSxcr
tyler-dane
marked this pull request as ready for review
October 22, 2026 03:20
tyler-dane
added
the
agent-automerge
Claude
tyler-dane
enabled auto-merge
October 22, 2026 03:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #4331
What and why
With #4717's popover capture, the macOS
event-form-time-pickerimage (run 39715292847) shows the start-time list open at 12 AM: 12 AM, 12:15, 12:30 and so on. The selected 3 PM is about 60 rows down. Web's time list opens centered on the selection (2:30, 2:45, 3 PM highlighted, 3:15, 3:30).This PR wraps the list in a
ScrollViewReader, gives each row its label as anid, and on appear scrolls the selected row to the center. When the time isn't on a quarter hour (3:10), it uses the quarter hour before it, so the list still opens next to the selection. The highlight logic is unchanged. It also updates the time-pickers row indocs/features/desktop-web-parity-checklist.md.Still different from web (noted in the checklist): macOS shows the time list and date picker as AppKit popovers, which can open to the side of the field. Web drops them below it.
Verify
VERDICT: PASSfrombun run verify --strict(type-check, lint, knip).bun cli contracts:swift --checkandbun cli desktop:export --checkpass.Not run locally: this cloud session has no Swift toolchain or Xcode, so the build only runs in macOS CI. There's no unit test because this is SwiftUI scroll behavior inside a popover. The evidence will be the
event-form-time-pickercapture on main once #4717 (popovers in captures) and #4720 (welcome capture fix) have merged.Generated by Claude Code