Repository navigation
fix(web): lowercase event jump labels and bare f4 targeting - #4723
Merged
Merged
Conversation
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Contributor
|
Boot bundle: 510.5 KB gzip (+0.0 KB vs main) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Reopens the work from closed #4689 after merge-queue failures. Root cause:
TimeGridDayJumpPrefixTestslanded onmainwith uppercase⇧SU/SUexpectations while this branch already rendered lowercase day-prefix chips; merge_group macOSswift-packagesfailed even though PR checks looked green.Rebased onto current
main, aligned macOS header + unit tests to lowercase prefixes, and kept the web jump-key behavior (lowercase chips, baref4targeting,Escto exit jump mode).Verify
bun test apps/calendar-web/src/shortcuts/shift-hint/assign-shift-hint-keys.test.ts— 17 pass.Merge queue note
Do not re-queue until macOS / Unit / E2E PR checks report on the latest commit.