Repository navigation
fix(macos): register the welcome account-choice parity surface - #4724
Merged
Merged
Conversation
The onboarding capture exports onboarding-welcome-account-choice, but the name was not a ParityCaptureSurface, so the debug URL never parsed and the export timed out. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GKHjv2HDx1DFAnG4cfSxcr
tyler-dane
marked this pull request as ready for review
October 22, 2026 04:42
tyler-dane
added
the
agent-automerge
Claude
tyler-dane
enabled auto-merge
October 22, 2026 04:42
tyler-dane
added
the
parity-screenshots
Claude
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Oct 22, 2026
…unt-choice-surface # Conflicts: # docs/features/desktop-web-parity-checklist.md
tyler-dane
enabled auto-merge
October 22, 2026 06:07
Contributor
|
Boot bundle: 512.1 KB gzip (+0.0 KB vs main) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Refs #4331
NativeParityCaptureTests.captureWelcomeOnboarding(from #4707) exports a second capture,onboarding-welcome-account-choice. That name was not aParityCaptureSurface, soDesktopDebugCommand.parsereturned nil, the app never wrote the PNG, andmacos-capturetimed out on every PR that touches CompassUI (seen on #4718 and #4720 once the earlier button-label failures were fixed).Cloud session: no macOS runner or Swift toolchain here, so the Swift test and capture run on CI only.
Verify
bun run verify --strictVERDICT: PASS
Generated by Claude Code