Repository navigation
fix(macos): order color swatches like web and fill the time list popover - #4725
Merged
Merged
Conversation
The generated EventColorSlot enum is alphabetical, so swatch positions and pick keys named different colors than web's EventColorSlotSchema order. The time list popover left the system material visible around the list, which the parity capture drew as a black frame. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GKHjv2HDx1DFAnG4cfSxcr
tyler-dane
marked this pull request as ready for review
October 22, 2026 06:08
tyler-dane
added
the
agent-automerge
Claude
tyler-dane
enabled auto-merge
October 22, 2026 06:09
tyler-dane
added
the
parity-screenshots
Claude
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Refs #4331
Two gaps from the #4717 parity compare:
EventColorSlotSchemaorder (lavender, mint, plum, coral, gold, orange, blue, slate, indigo, green, red). The generated SwiftEventColorSlotis alphabetical, so the same position, and the same pick key (from feat(macos): move between color swatches with arrows and pick keys like web #4714), chose a different color on macOS.EventColorSlot.webOrdernow drivescolorSwatchOptions, which feeds the swatch grid and the pick keys..presentationBackground(theme.surfacePanelColor)fills it like the date popover. I dropped the inner clip and shadow because the popover already draws both.Tests:
EventColorSlotOrderTests(every slot once, lavender first) andEventFormColorSwatchKeysTestsnow pins pick key 1 to lavender.Cloud session: no macOS runner or Swift toolchain here, so Swift tests and the capture run on CI only.
Verify
bun run verify --strict,bun cli contracts:swift --check,bun cli desktop:export --checkVERDICT: PASS
Generated by Claude Code