Skip to content

Using remote_options with multiple flags to rsync causes rsync to fail. #31

Description

@AniAggarwal

Example configs that fail:

remote_or_local remote
remote_options  -vazre --existing

remote_or_local remote
remote_options  -vazr --existing -e

Seems the issue with that rsync interperts the -vazr --existing -e as one single option. On the other hand, using -vazre --existing makes rsync think that the command it is executing (after the -e flag) is --existing which causes it to fail as well.

This looks like it may need a fair amount of work needed to process the flags and then place them in the cmd variable separately to ensure they are passed to rsync correctly.
Let me know if I am not understanding the problem.
If there is interest, I can look into making this work.

EDIT:
Actually, after some more experimenting with rsync it seems all we need to do is remove a -e flag in the remote_options input and then throw the -e on after the options, just before ssh -p PORT.
I'm not sure, however, if we will need to split something like --existing -e -vaz -r --progress into [--existing, -vaz, -r, --progress] before adding -e 'ssh -p PORT' ....

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions