Repository navigation
Run the scaffold's serve command with its extra - #46
Merged
Merged
Conversation
A new world's README.md and AGENTS.md said `uv run seahaven serve`. The next steps `seahaven new` prints say `uv sync`, which installs no extra, so that command failed with "seahaven serve needs the serve extra". Both now say `uv run --extra serve seahaven serve`, the form the framework README already uses. The new test reads every `uv run` command in the scaffold's docs and fails on a `seahaven serve` or `seahaven mcp` without its extra. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UkCSvbssGtXeqthAaZsmmt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while testing the live 0.5.0 release from PyPI.
A world made by
seahaven newhas aREADME.mdand anAGENTS.mdthat say to serve it withuv run seahaven serve. The next stepsseahaven newprints sayuv sync, which installs no extras, so that command fails:Both templates now say
uv run --extra serve seahaven serve, which matches the framework README. I ran that command against a live 0.5.0 scaffold, and it serves.Test
test_the_scaffold_docs_run_each_server_with_its_extrareads every`uv run …`command in the scaffold'sREADME.mdandAGENTS.md. It fails if aseahaven serveorseahaven mcpcommand lacks its--extra. It also fails if it finds no server command at all, so the test can't pass by checking nothing. With the template fix reverted, it fails with'uv run seahaven serve' lacks --extra serve.Checks
ruff format --check,ruff check,ty check(serve split): cleanuv run pytest(serve): 2448 passed, 4 skipped, 4 xfailedtests/test_cli_new.pyin the mcp environment: passesThe fix reaches users in the next release, because the templates ship in the wheel.
🤖 Generated with Claude Code
https://claude.ai/code/session_01UkCSvbssGtXeqthAaZsmmt
Generated by Claude Code