Repository navigation
feat(gateway): expose active experiment models - #3386
Conversation
|
|
||
| filteredModels.push(...(await getDirectByokModelsForOrganization(organizationId))); | ||
| filteredModels.push(...(await listAvailableCustomLlms(organizationId))); | ||
| filteredModels.push(...(await listAvailableExperimentModels())); |
There was a problem hiding this comment.
WARNING: Experiment models bypass enterprise model restrictions
Experiment models are appended to filteredModels after the hasActiveModelRestrictions block (lines 31–39), meaning they are never evaluated against modelDenyList or providerAllowList. This is consistent with the PR description ("independent of organization model restrictions"), but it means enterprise customers with a strict provider allow-list or model deny-list will still see and can select active experiment models.
If this is intentional, a comment here would make the policy explicit for future maintainers — e.g.:
// Experiment models are intentionally exempt from org-level restrictions so
// preview experiments are always reachable during the experiment period.If it is not intentional, the isAllowed predicate should be applied to experiment models the same way it is applied to the main responseData.data.
There was a problem hiding this comment.
I'll look into it, for now i dont think it matters much either way , model usage is enforced when using
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryThe previously flagged WARNING — experiment models bypassing enterprise Resolved Issues
Files Reviewed (5 files)
Reviewed by claude-sonnet-4.6 · 241,536 tokens Review guidance: REVIEW.md from base branch |
Summary
Verification
kilo/preview-henkexperiment and confirmed it appeared in the local model selector.Visual Changes
N/A
Reviewer Notes