Repository navigation
test(experiments): preserve attribution on soft delete - #3456
Merged
Merged
Conversation
markijbema
marked this pull request as ready for review
May 25, 2026 11:44
markijbema
enabled auto-merge (squash)
May 25, 2026 11:45
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryTest-only PR adding a well-structured regression test for soft-delete retention of Files Reviewed (3 files)
Reviewed by claude-sonnet-4.6 · 537,354 tokens Review guidance: REVIEW.md from base branch |
imanolmzd-svg
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
softDeleteUserregression test proving model experiment attribution rows and prompt hashes remain after account soft-delete.model_experiment_requestin the soft-delete retained-records policy comment.Verification
N/A — test/docs only.
Visual Changes
N/A
Reviewer Notes
mainrather than stacking onto that branch.softDeleteUserdoes not interact with the R2 prompt bucket.