Skip to content

test(experiments): preserve attribution on soft delete - #3456

Merged
markijbema merged 1 commit into
mainfrom
mark/model-experiment-soft-delete-test
May 25, 2026
Merged

markijbema merged 1 commit into
mainfrom
mark/model-experiment-soft-delete-test

Conversation

@markijbema

Copy link
Copy Markdown
Contributor

Summary

  • Adds a softDeleteUser regression test proving model experiment attribution rows and prompt hashes remain after account soft-delete.
  • Documents model_experiment_request in the soft-delete retained-records policy comment.
  • Updates the experimental-models plan to mark the soft-delete policy test as present and keep the remaining Phase 6 work focused on the durable spec/AGENTS registration.

Verification

N/A — test/docs only.

Visual Changes

N/A

Reviewer Notes

@markijbema
markijbema marked this pull request as ready for review May 25, 2026 11:44
@markijbema
markijbema enabled auto-merge (squash) May 25, 2026 11:45
@kilo-code-bot

kilo-code-bot Bot commented May 25, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

Test-only PR adding a well-structured regression test for soft-delete retention of model_experiment_request rows; logic, assertions, and schema usage are all correct.

Files Reviewed (3 files)
  • .plans/experimental-models-1.md — documentation updates reflecting correct test file path and revised status
  • apps/web/src/lib/user/index.test.ts — new regression test for soft-delete experiment attribution retention
  • apps/web/src/lib/user/index.ts — softDeleteUser JSDoc updated to document model_experiment_request retention policy

Reviewed by claude-sonnet-4.6 · 537,354 tokens

Review guidance: REVIEW.md from base branch main

@markijbema
markijbema merged commit d76383c into main May 25, 2026
13 checks passed
@markijbema
markijbema deleted the mark/model-experiment-soft-delete-test branch May 25, 2026 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants