Repository navigation
fix(mobile): make the session context circle tappable in every state - #6190
Merged
Merged
Conversation
iscekic
marked this pull request as draft
September 15, 2026 22:31
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryThe follow-up commit addresses both prior findings on changed lines: an open request recorded before usage is reported no longer dismisses the sheet, and auto-reply eligibility is now split from settings reachability. No new defects found in the changed code. Overview
Files Reviewed (5 files)
Notes
Previous Review Summary (commit 2d23c92)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 2d23c92)Status: 2 Issues Found | Recommendation: Address before merge Executive SummaryThe new "open the sheet in every state" path stores an identity without provider/model, so on a read-only session the sheet dismisses itself the moment usage data arrives. Overview
Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (8 files)
Notes
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
iscekic
force-pushed
the
kwf/context-circle-always-tappable-33a0
branch
from
September 15, 2026 23:08
2d23c92 to
1b8ab24
Compare
iscekic
marked this pull request as ready for review
September 15, 2026 23:28
eshurakov
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog for users
Changelog for maintainers
canAutoApprovePermissions(session-auto-approve.ts) treats an unresolved transport (null) as available; only a session known to be read-only is unavailable.getContextSheetMountState(context-usage-display.ts) mounts the sheet once it has been opened for the current session, even before usage or permission controls are known; visibility still requires the matching session identity.SessionContextMetrics(session-context-metrics.tsx) bases pressability ononPress != null;hiddennow applies only to the no-onPressplaceholder.SessionDetailContent(session-detail-content.tsx) always passes the sheet-openingonPress; it no longer gates the callback on context info or auto-approve availability.E2E proof
Owner request
[e4] While the offline banner is visible (airplane mode), tap the context circle: the sheet still opens (proves the banner overlay does not swallow the tap). — android emulator-5554; offline banner raised with fault.sh down nextjs plus wifi/data off, then restored (up nextjs + radio enable). e4-run.log line 1 'SCENE e4 OK' with no MISS lines, and its closing digest carries both 'No internet connection' [0,128][1080,223] and the pill 'Context 17,763 of 1,310,720 tokens, 1% used, cost 1 cent. Tap to view context details.'; the ordered steps asserted the banner before tapping that pill and asserted 'Context usage' and 'Auto-approve' after, so the context sheet opened while the banner was up (e4-offline-banner.log holds the same banner+pill digest as a…
e4-offline-tap.mp4.trim.mp4
[e4] While the offline banner is visible (airplane mode), tap the context circle: the sheet still opens (proves the banner overlay does not swallow the tap). — android emulator-5554; offline banner raised with fault.sh down nextjs plus wifi/data off, then restored (up nextjs + radio enable). e4-run.log line 1 'SCENE e4 OK' with no MISS lines, and its closing digest carries both 'No internet connection' [0,128][1080,223] and the pill 'Context 17,763 of 1,310,720 tokens, 1% used, cost 1 cent. Tap to view context details.'; the ordered steps asserted the banner before tapping that pill and asserted 'Context usage' and 'Auto-approve' after, so the context sheet opened while the banner was up (e4-offline-banner.log holds the same banner+pill digest as a…
[e4] On a read-only session, tap the context circle: the sheet opens with usage details and the Auto-approve row shown as unavailable. — android emulator-5604: after the circle on the read-only fixture was tapped, e4-scene.log (lines 146-182) holds 'android.view.View Context usage', 'android.view.ViewGroup session-auto-approve-row', 'android.widget.TextView Auto-approve', 'android.widget.TextView This session cannot receive permission asks.' and 'android.widget.TextView 1,375 of 1,000,000 tokens' beside 'android.widget.TextView Mobile sheet fixtures'/'ses_000000000001RootFixture001'; the run's only MISS was its end anchor 'Agents, tab, 2 of 3' (the sheet hides the tab bar), no assertion failed, replay banked at e4.replay.json…
[e3] Context usage sheet opens on a loaded session showing a PR badge next to the circle — android emulator-5554: e3c-scene.log line 7 shows 'android.widget.Button open pull request #1' beside the circle on the loaded session, and after tapping the circle e3d-scene.log shows 'android.view.View Context usage' with 'session-auto-approve-row' and 'Auto-approve' (stills e3c.png/e3d.png left for the visual reviewer); no functional UX defect observed in the states visited.
[e4] On a read-only session, tap the context circle: the sheet opens with usage details and the Auto-approve row shown as unavailable. — android emulator-5604: after the circle on the read-only fixture was tapped, e4-scene.log (lines 146-182) holds 'android.view.View Context usage', 'android.view.ViewGroup session-auto-approve-row', 'android.widget.TextView Auto-approve', 'android.widget.TextView This session cannot receive permission asks.' and 'android.widget.TextView 1,375 of 1,000,000 tokens' beside 'android.widget.TextView Mobile sheet fixtures'/'ses_000000000001RootFixture001'; the run's only MISS was its end anchor 'Agents, tab, 2 of 3' (the sheet hides the tab bar), no assertion failed, replay banked at e4.replay.json…
Follow-ups (not changed here)
Open findings (not fixed here)
e4-offline-tap.mp4