Repository navigation
Conversation
Explorer finding: pr-detail: The primary "Submit review" button in the header is clipped by the right screen edge, cutting off its label. The user-agent explorer found this while using the app like a user. One finding per item; the explorer never edits product code. Flow: pr-detail Found on revision: 25e16c1 Repro: 1. set this state first: account e2e-mobile-cloud-android@example.com signed in, $10 credits, 5 Code Reviewer pull requests, a second organization to switch to, font scale 2, battery 55% discharging, device portrait. 2. open the app on emulator-5554 3. reach the screen the capture names (pr-detail) 4. the capture shows the defect named below Observed: The primary "Submit review" button in the header is clipped by the right screen edge, cutting off its label. Expected: the screen renders without this defect Evidence (from the device run): - ~/.local/share/kwf/findings/explorer-pr-detail-the-primary-submit-review-button-in-th-d85029b9/pr-detail.png
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Reviewed the mobile header fix that lets the Overview "Submit review" button shrink and wrap at large font scales. The Files Reviewed (2 files)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
|
This description names a scenario the proof did not capture:
A repeated proof run rebuilds the same evidence, so no proof run is dispatched for a named gap. Merging with this gap open is your decision. |
eshurakov
left a comment
There was a problem hiding this comment.
Approved after a shallow triage pass. No blocking findings.
Changelog for users
Changelog for maintainers
min-w-0 shrink), overriding the Button's baseshrink-0, so it stays inside the trailing header slot's half-width cap.shrink text-center) with no line cap and font scaling left enabled; the button's minimum height lets it grow taller for a second line.E2E proof
[e1] pr-detail header Submit review fits at font scale 2 (android) — android emulator-5554, kilo-stub/discussion-mixed #1 Overview, font scale 2.0 (e1-font-scale.log): e1-scene.log shows 'SCENE e1 OK', button 'Submit review' [641,213][1043,396] with right edge 1043 inside the 1080 screen, label [719,226][1016,382] two lines and fully inside the button; label complete/unclipped (e1.png for the visual reviewer).
[e2] pr-detail header Submit review one line at font scale 1 (android) — android emulator-5554, same screen, font scale 1.0 (e2-font-scale.log): e2-scene.log shows 'SCENE e2 OK', label TextView 'Submit review' [806,197][1016,243] height 46 (one line) and button [728,173][1043,268], same header elements and right-edge alignment 1043 as at scale 2; appearance is the visual reviewer's (e2.png).
E2E proof — log excerpts
/home/igor_kilocode_ai/.local/share/kwf/sections/explorer-pr-detail-the-primary-submit-review-button-in-th-d8502-a923/e2e-mobile-app/e1-scene.log/home/igor_kilocode_ai/.local/share/kwf/sections/explorer-pr-detail-the-primary-submit-review-button-in-th-d8502-a923/e2e-mobile-app/e1-font-scale.log/home/igor_kilocode_ai/.local/share/kwf/sections/explorer-pr-detail-the-primary-submit-review-button-in-th-d8502-a923/e2e-mobile-app/e2-scene.log/home/igor_kilocode_ai/.local/share/kwf/sections/explorer-pr-detail-the-primary-submit-review-button-in-th-d8502-a923/e2e-mobile-app/e2-font-scale.logOwner request
Follow-ups (not changed here)
Open findings (not fixed here)