Skip to content

fix(mobile): keep the Submit review header button label on screen - #6328

Merged
iscekic merged 1 commit into
mainfrom
kwf/explorer-pr-detail-the-primary-submit-review-button-in-th-d8502-a923
Sep 21, 2026
Merged

iscekic merged 1 commit into
mainfrom
kwf/explorer-pr-detail-the-primary-submit-review-button-in-th-d8502-a923

Conversation

@iscekic

@iscekic iscekic commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator

Changelog for users

  • The "Submit review" button in the pull request header shows its full label at large font scales.
  • The label wraps onto a second line when it does not fit, instead of being cut off by the right screen edge.
  • At the default font scale the button keeps its label on one line and the header looks unchanged.

Changelog for maintainers

  • The header action button now shrinks (min-w-0 shrink), overriding the Button's base shrink-0, so it stays inside the trailing header slot's half-width cap.
  • The label wraps (shrink text-center) with no line cap and font scaling left enabled; the button's minimum height lets it grow taller for a second line.
  • Added unit coverage asserting the button shrinks and the label can wrap.
  • Review first the PR Overview header at a large font scale: a long translated label now wraps and raises the header height.

E2E proof

[e1] pr-detail header Submit review fits at font scale 2 (android) — android emulator-5554, kilo-stub/discussion-mixed #1 Overview, font scale 2.0 (e1-font-scale.log): e1-scene.log shows 'SCENE e1 OK', button 'Submit review' [641,213][1043,396] with right edge 1043 inside the 1080 screen, label [719,226][1016,382] two lines and fully inside the button; label complete/unclipped (e1.png for the visual reviewer).

[e1] pr-detail header Submit review fits at font scale 2 (android) — e2e-mobile-app/e1.png

[e2] pr-detail header Submit review one line at font scale 1 (android) — android emulator-5554, same screen, font scale 1.0 (e2-font-scale.log): e2-scene.log shows 'SCENE e2 OK', label TextView 'Submit review' [806,197][1016,243] height 46 (one line) and button [728,173][1043,268], same header elements and right-edge alignment 1043 as at scale 2; appearance is the visual reviewer's (e2.png).

[e2] pr-detail header Submit review one line at font scale 1 (android) — e2e-mobile-app/e2.png

E2E proof — log excerpts

[e1] pr-detail header Submit review fits at font scale 2 (android) -> pass :: android emulator-5554, kilo-stub/discussion-mixed #1 Overview, font scale 2.0 (e1-font-scale.log): e1-scene.log shows 'SCENE e1 OK', button 'Submit review' [641,213][1043,396] with right edge 1043 inside the 1080 screen, label [719,226][1016,382] two lines and fully inside the button; label complete/unclipped (e1.png for the visual reviewer).
[e2] pr-detail header Submit review one line at font scale 1 (android) -> pass :: android emulator-5554, same screen, font scale 1.0 (e2-font-scale.log): e2-scene.log shows 'SCENE e2 OK', label TextView 'Submit review' [806,197][1016,243] height 46 (one line) and button [728,173][1043,268], same header elements and right-edge alignment 1043 as at scale 2; appearance is the visual reviewer's (e2.png).
/home/igor_kilocode_ai/.local/share/kwf/sections/explorer-pr-detail-the-primary-submit-review-button-in-th-d8502-a923/e2e-mobile-app/e1-scene.log
android.widget.TextView Mixed discussion fixture tappable [37,835][1045,958]
android.widget.TextView alice tappable [110,987][245,1065]
android.widget.TextView feature/stub tappable [92,1092][568,1180]
android.widget.TextView ← tappable [586,1097][650,1175]
android.widget.TextView main tappable [668,1092][827,1180]
android.widget.TextView 1 commit tappable [87,1208][359,1286]
android.widget.TextView 2 files tappable [446,1208][620,1286]
android.widget.TextView 10 tappable [708,1208][781,1286]
android.widget.TextView / −2 tappable [795,1208][909,1286]
android.widget.TextView Opened 6 months ago · Updated 2 hours ago tappable [37,1332][1045,1488]
android.widget.TextView LABELS tappable [37,1525][235,1596]
android.widget.TextView bug tappable [59,1623][154,1692]
android.widget.TextView documentation tappable [214,1623][593,1692]
android.widget.TextView good first issue tappable [59,1724][447,1793]
android.widget.TextView REVIEWERS tappable [82,1839][379,1910]
android.widget.TextView carol tappable [110,1928][730,2006]
android.widget.TextView Approved tappable [803,1932][1043,2001]
android.widget.TextView dave tappable [110,2025][485,2103]
android.widget.TextView Changes requested tappable [558,2029][1043,2098]
android.widget.TextView erin tappable [110,2121][662,2199]
android.widget.TextView Commented tappable [735,2125][1043,2194]
android.widget.TextView frank tappable [110,2218][575,2296]
android.widget.TextView Awaiting review tappable [648,2222][1043,2291]
android.widget.TextView ASSIGNEES tappable [82,2333][379,2400]
/home/igor_kilocode_ai/.local/share/kwf/sections/explorer-pr-detail-the-primary-submit-review-button-in-th-d8502-a923/e2e-mobile-app/e1-font-scale.log
emulator-5554 android settings get system font_scale, read immediately after set (e1 context):
2.0
/home/igor_kilocode_ai/.local/share/kwf/sections/explorer-pr-detail-the-primary-submit-review-button-in-th-d8502-a923/e2e-mobile-app/e2-scene.log
android.widget.TextView Mixed discussion fixture tappable [37,596][1045,674]
android.widget.TextView alice tappable [110,707][180,753]
android.widget.TextView feature/stub tappable [92,785][344,832]
android.widget.TextView ← tappable [362,785][395,831]
android.widget.TextView main tappable [413,785][497,832]
android.widget.TextView 1 commit tappable [87,860][227,906]
android.widget.TextView 2 files tappable [314,860][404,906]
android.widget.TextView 10 tappable [492,860][530,906]
android.widget.TextView / −2 tappable [544,860][603,906]
android.widget.TextView Opened 6 months ago · Updated 2 hours ago tappable [37,952][1045,998]
android.widget.TextView LABELS tappable [37,1035][138,1072]
android.widget.TextView bug tappable [59,1099][107,1136]
android.widget.TextView documentation tappable [167,1099][357,1136]
android.widget.TextView good first issue tappable [416,1099][610,1136]
android.widget.TextView REVIEWERS tappable [82,1182][234,1219]
android.widget.TextView carol tappable [110,1241][850,1287]
android.widget.TextView Approved tappable [923,1246][1043,1283]
android.widget.TextView dave tappable [110,1315][727,1361]
android.widget.TextView Changes requested tappable [800,1320][1043,1357]
android.widget.TextView erin tappable [110,1388][816,1434]
android.widget.TextView Commented tappable [889,1393][1043,1430]
android.widget.TextView frank tappable [110,1462][772,1508]
android.widget.TextView Awaiting review tappable [845,1467][1043,1504]
android.widget.TextView ASSIGNEES tappable [82,1550][234,1587]
/home/igor_kilocode_ai/.local/share/kwf/sections/explorer-pr-detail-the-primary-submit-review-button-in-th-d8502-a923/e2e-mobile-app/e2-font-scale.log
device emulator-5554 font scale read (e1 run context):
1.0
Owner request

Explorer finding: pr-detail: The primary "Submit review" button in the header is clipped by the right screen edge, cutting off its label.

The user-agent explorer found this while using the app like a user.
One finding per item; the explorer never edits product code.

Flow: pr-detail
Found on revision: 25e16c1

Repro:

  1. set this state first: account e2e-mobile-cloud-android@example.com signed in, $10 credits, 5 Code Reviewer pull requests, a second organization to switch to, font scale 2, battery 55% discharging, device portrait.
  2. open the app on emulator-5554
  3. reach the screen the capture names (pr-detail)
  4. the capture shows the defect named below

Observed: The primary "Submit review" button in the header is clipped by the right screen edge, cutting off its label.
Expected: the screen renders without this defect

Evidence (from the device run):

Follow-ups (not changed here)

  • not proved live: At font scale 1 on the same screen, the header "Submit review" button keeps its label on one line and the header layout is unchanged. (no capture cited it)
  • not proved live: On emulator-5554, sign in as e2e-mobile-cloud-android@example.com with font scale 2, open the pr-detail screen (kilo-stub/discussion-mixed refactor(bot): Extract platform-agnostic tool system #1) on the Overview tab: the header "Submit review" button shows its complete label (on two lines if needed) and is not cut off by the right screen edge. (no capture cited it)

Open findings (not fixed here)

  • not proved live: pr-detail.png is no longer on the host that took it, so no publish can carry it

Explorer finding: pr-detail: The primary "Submit review" button in the header is clipped by the right screen edge, cutting off its label.

The user-agent explorer found this while using the app like a user.
One finding per item; the explorer never edits product code.

Flow: pr-detail
Found on revision: 25e16c1

Repro:
1. set this state first: account e2e-mobile-cloud-android@example.com signed in, $10 credits, 5 Code Reviewer pull requests, a second organization to switch to, font scale 2, battery 55% discharging, device portrait.
2. open the app on emulator-5554
3. reach the screen the capture names (pr-detail)
4. the capture shows the defect named below

Observed: The primary "Submit review" button in the header is clipped by the right screen edge, cutting off its label.
Expected: the screen renders without this defect

Evidence (from the device run):
- ~/.local/share/kwf/findings/explorer-pr-detail-the-primary-submit-review-button-in-th-d85029b9/pr-detail.png
@kilo-code-bot

kilo-code-bot Bot commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Reviewed the mobile header fix that lets the Overview "Submit review" button shrink and wrap at large font scales. The min-w-0 shrink override correctly supersedes the Button base shrink-0 via tailwind-merge, the label keeps scaling and wrapping enabled, and the new unit tests match the established className-assertion pattern used elsewhere in the codebase. No memory-leak risk is introduced (no effects, subscriptions, or refs added).

Files Reviewed (2 files)
  • apps/mobile/src/components/pr-review/pr-review-screen.tsx
  • apps/mobile/src/components/pr-review/pr-review-screen.test.tsx

Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0

Review guidance: REVIEW.md from base branch main

@iscekic

iscekic commented Sep 19, 2026

Copy link
Copy Markdown
Collaborator Author

This description names a scenario the proof did not capture:

  • not proved live: At font scale 1 on the same screen, the header "Submit review" button keeps its label on one line and the header layout is unchanged. (no capture cited it)

A repeated proof run rebuilds the same evidence, so no proof run is dispatched for a named gap. Merging with this gap open is your decision.

@iscekic iscekic added the human-ready The PR is ready for human review. label Sep 19, 2026
@iscekic iscekic self-assigned this Sep 19, 2026

@eshurakov eshurakov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after a shallow triage pass. No blocking findings.

@iscekic
iscekic merged commit bad14ef into main Sep 21, 2026
29 checks passed
@iscekic
iscekic deleted the kwf/explorer-pr-detail-the-primary-submit-review-button-in-th-d8502-a923 branch September 21, 2026 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

human-ready The PR is ready for human review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants