Repository navigation
fix(mobile): polish pull request review UX papercuts - #6343
Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryFresh full review at HEAD baa897c after this branch's history was rewritten: the header Merge CTA mirrors the Overview merge section's gate and route across every mergeability state and provider, the context sheet's extracted copy rows are generation-guarded, leak-free, and fed the same anchor as the removed header action, and the padding changes carry no layout or safe-area side effects. No issues found. Files Reviewed (16 files)
Previous Review Summaries (3 snapshots, latest commit c7a945c)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit c7a945c)Status: No Issues Found | Recommendation: Merge Executive SummaryFresh review of the rebased UX-papercut change at HEAD c7a945c: the copy-link row's generation-guarded inline feedback is leak-free and race-safe, the header Merge CTA exactly mirrors the Overview merge section's gate and route, the loading-header copy removal is intentional and now documented and test-pinned, and the padding changes have no list-padding side effects — no issues found. Files Reviewed (15 files)
Previous reviewStatus: No Issues Found | Recommendation: Merge Executive SummaryThe rebased mobile UX-papercut change holds together: the loading header comment now matches the loaded right cluster, the new copy-link row and its generation-guarded inline feedback are sound, and the header Merge CTA mirrors the Overview merge gate. The previously raised warning is resolved. Files Reviewed (15 files)
Previous review (commit 6f6b98e)Status: 1 Issue Found | Recommendation: Address before merge Executive SummaryThe loading state of the session screen loses its only copy-link affordance because the sheet it moved into is not mounted there, and the replacement comment misdescribes the loaded header's right cluster. Overview
Issue Details (click to expand)WARNING
Files Reviewed (15 files)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
|
bot: Rejected, no code change (kwf Why: (already implemented, verified live: no change needed: The requested cross-platform clipboard and success-haptic implementation already exists, and targeted checks found no platform fork. Existing implementation: apps/mobile/src/components/agents/session-row-actions.ts:67 calls Clipboard.setStringAsync and Haptics.notificationAsync wit |
d79e5ad to
c3296af
Compare
c3296af to
c7a945c
Compare
eshurakov
left a comment
There was a problem hiding this comment.
Approved after a shallow triage pass. No blocking findings.
8edc85d to
baa897c
Compare
Changelog for users
Changelog for maintainers
py-2topy-4; the gutter, background, and hairline are unchanged.24 + insets.bottomtoMath.max(insets.bottom, 8); landscape side insets are untouched.Button size="icon" variant="ghost"; Submit review still renders only on the Overview tab.anchorMessageId; both copy rows share an extractedCopyRowand auseCopyRowFeedbackhook guarded by a generation counter.copySessionLinkwas added to the session row actions, andsession-copy-link-action.tsxwas deleted, so the loading header no longer reserves that control.common.copyLink,prReview.merge.mergeNow,agentChat.chatLink.linkCopied, andagentChat.chatLink.couldNotCopyLink.E2E proof
/home/igor_kilocode_ai/.local/share/kwf/sections/kwf-fix-proof-c3296af-ac0d/e2e-mobile-app/e1-files-scenes2.log/home/igor_kilocode_ai/.local/share/kwf/sections/kwf-fix-proof-c3296af-ac0d/e2e-mobile-app/e1-header.log/home/igor_kilocode_ai/.local/share/kwf/sections/kwf-fix-proof-c3296af-ac0d/e2e-mobile-app/e1-merge-scene.log/home/igor_kilocode_ai/.local/share/kwf/sections/kwf-fix-proof-c3296af-ac0d/e2e-mobile-app/e1-context-scene.logOpen findings (not fixed here)
mobile-device: verifier passed
mobile-device: spot skips 2 still(s) of missed scripted scene(s)
mobile-device: spot check clean
mobile-device: signed-in app data restored on emulator-5554
mobile-device: signed-in app data frozen on emulator-5554 (66547200 bytes)