Skip to content

fix(mobile): correct Thai PR review terminology - #7999

Merged
iscekic merged 2 commits into
mainfrom
drain/thai-pr-review-terminology
Oct 21, 2026
Merged

iscekic merged 2 commits into
mainfrom
drain/thai-pr-review-terminology

Conversation

@iscekic

@iscekic iscekic commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

bot: Summary
Align the Thai PR-review strings in apps/mobile/src/i18n/locales/th.json on one term per concept, keeping every key and placeholder:

  • One review term: prReview.submit.submitReview, prReview.overview.reviewers, prReview.overview.reviewPending now share the same loanword; prReview.overview.stateOpenReviewRequired becomes "เปิด · ต้องรีวิว" so the review-required meaning survives.
  • One merge verb: prReview.merge.merge and prReview.merge.methods.merge match the รวม family already used by every phrase-based merge key.
  • One expand verb: all hunk expand controls and their plural variants — including the partial "expand more" label — use ขยาย.
  • Consistent pull-request noun: prReview.merge.blocked.draftTitle, prReview.linkPasteNotAPullRequest, and agentChat.prBadge.draft use PR where sibling copy already does; merge request stays as the accepted loanword.
  • Corrected strings: the รีวิวน misspelling in prReview.entry.removeFromRecentsMessage, the pR casing in prReview.pendingComment.staleHint, the prReview.discussion.reaction_one count noun now matching reaction/reaction_other, and prReview.mutationError.reviewNotSubmitted now renders the same first sentence as reviewNotSubmittedTerm.
  • prReview.terms.mergeRequestNumber keeps the Merge request noun its English source carries.

prReview.review keeps การตรวจสอบ and prReview.reviewPullRequest becomes "การตรวจสอบ PR" so the visible review button and its accessibility label agree: English "Review" is also rendered การตรวจสอบ by a key outside this work item, and the one-wording-per-source catalog check requires a single rendering per English string.

Verification

  • pnpm --filter kilo-app run check:i18n — catalog parity and wording checks pass (87 languages).
  • pnpm --filter kilo-app run check:plurals — every counted message declares its plural categories.

Proxy answers

These answers are advisory input from the owner's proxy, given in the owner's place.

  1. Question: Review term: stateOpenReviewRequired becomes "เปิด · ต้องรีวิว". The finding's recommendation suggested building on ตรวจทาน ("เปิด · ต้องตรวจทาน"), but the work-item brief explicitly says "use รีวิว as the one review term … and the reviewers/reviewPending siblings". Which direction for reviewers (ผู้ตรวจทาน) and reviewPending (รอการตรวจทาน)?
    Answer: รีวิว everywhere (ผู้รีวิว, รอรีวิว)
    Confidence: 0.90 · Precedent: Fix the root cause and the class of the issue: session 00eb2a1d3e4b, "if anything repeats the same mistake over and over again, fix the class". The brief also names the reviewers/reviewPending siblings explicitly.
  2. Question: Merge verb: The merge verb: finding Admin - Add App Builder project detail page with session traces link #6 recommends aligning the button (merge, methods.merge) to รวม since every phrase-based key already uses รวม/การรวม. Confirm รวม?
    Answer: รวม (align button to the rest)
    Confidence: 0.92 · Precedent: Do the least work possible with no drop in quality: session 7f3470e0ba6f, "do the least amount of work possible, with no drop in quality". The brief also says to use รวม like every other merge action.

Use one review term (รีวิว) across the prReview review-family keys, one
merge verb (รวม) for the standalone merge labels, one expand verb
(ขยาย) for the hunk expand controls, and PR for pull request where the
sibling copy already uses the acronym. Fix the รีวิวน misspelling, the
pR casing, the reaction_one count noun, and restore the Merge request
noun in the merge-request number title. Keep every key and placeholder.
@iscekic iscekic added drain Work item from the findings drain janitor:i18n Janitor finding: mobile copy and catalog checks labels Oct 19, 2026
@kilo-code-bot

kilo-code-bot Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

The incremental change rewords only three Thai expandMoreLines values to the ขยาย expand verb already used by the sibling hunk controls, with keys, placeholders, and plural variants intact.

Overview

The latest commit (0795fbc) touched a single locale file with 3 changed lines:

  • expandMoreLines (line 354) plus its _one (line 381) and _other (line 382) variants now read ขยายเพิ่มอีก {{displayCount}} บรรทัด ({{start}}–{{end}}), matching expandContext, expandMoreContext, expandLines, and expandAll which all use ขยาย.

Verification performed:

  • Confirmed the incremental diff is value-only (3 insertions / 3 deletions); no key was added, renamed, or removed.
  • Checked {{displayCount}}, {{start}}, and {{end}} placeholder parity against en.json (expandMoreLines_one/expandMoreLines/expandMoreLines_other) — the placeholder sets are identical.
  • Confirmed the _one and _other plural variants remain consistent with the base key and that English plural categories still hold for check:plurals.
  • Confirmed expandMoreLines is now internally consistent and that no other Thai key renders the same "Expand more {{count}} lines" source differently.
  • No inline comments were active on this PR; nothing to reconcile.
  • No potential memory-leak surface and no markdown/image content (locale catalog only).
Files Reviewed (1 file)
  • apps/mobile/src/i18n/locales/th.json
Previous Review Summary (commit 2736f86)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 2736f86)

Status: No Issues Found | Recommendation: Merge

Executive Summary

Reviewed the Thai PR-review terminology alignment in apps/mobile/src/i18n/locales/th.json; every changed line swaps copy only, with keys, placeholders, plural families, and the one-wording-per-English-string groups remaining consistent.

Files Reviewed (1 file)
  • apps/mobile/src/i18n/locales/th.json

Verification performed:

  • Confirmed the diff touches values only (23 insertions / 23 deletions); no key was renamed or removed.
  • Checked {{...}} placeholder parity against en.json for every changed key (including expandLines, expandLinesOfContext, mergeRequestNumber, and the _one/_other plural variants).
  • Checked the "one wording per English string" groups affected by the edits: Review (prReview.review, kiloclaw…flow.review, securityAgent.reviewDetail.title) remains การตรวจสอบ; Merge (prReview.merge.merge, prReview.merge.methods.merge) is now uniformly รวม; reactions (reaction, reaction_other) and draft pull request (prReview.merge.blocked.draftTitle, agentChat.prBadge.draft) stay internally consistent.
  • Confirmed English plural families still carry the categories Thai requires (_other), so check:plurals expectations hold.
  • No potential memory-leak surface (this change is a locale catalog only). No markdown/image content in this PR.

Reviewed by deepseek-v4.1-flash · Input: 33.4K · Output: 2.8K · Cached: 231.9K

Review guidance: REVIEW.md from base branch main

The partial hunk-expand label was the last Expand control still using a
different verb; align its bare and plural forms with the rest of the
family.
@iscekic iscekic added merge:human Substantive functional risk requires human review. merge:bot Bot-owned review; merge when ready once readiness passes and a review approves. and removed merge:human Substantive functional risk requires human review. labels Oct 19, 2026
@iscekic
iscekic added this pull request to the merge queue Oct 21, 2026
Merged via the queue into main with commit a6bb535 Oct 21, 2026
46 checks passed
@iscekic
iscekic deleted the drain/thai-pr-review-terminology branch October 21, 2026 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

drain Work item from the findings drain janitor:i18n Janitor finding: mobile copy and catalog checks merge:bot Bot-owned review; merge when ready once readiness passes and a review approves.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants