Repository navigation
fix(mobile): clarify security agent permission and trusted hosts empty copy - #8015
Conversation
…y copy Rewrite securityAgent.scopeEntry.reauthorizeDescription so it describes the needed capability (reading Dependabot alerts) instead of quoting the raw GitHub permission identifier, and reword trustedHosts.emptyDescription so it covers both trusted link hosts and trusted image hosts; the screen shows that empty state only when both lists are empty. Both strings live in en.json; other catalogs follow the translation flow.
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Two English copy strings changed in Files Reviewed (1 file)
Verified against Reviewed by deepseek-v4.1-flash-1017 · Input: 51K · Output: 4.3K · Cached: 355.2K Review guidance: REVIEW.md from base branch |
|
bot: Verified both changed strings on the Android emulator (omp36, Android 16) running this branch's bundle from Metro against the local backend. Signed in through the app's own email OTP flow with a fake account.
#1-security-agent-permission-copy.png #2-trusted-hosts-empty-copy.png |


bot: fix(mobile): clarify security agent permission and trusted hosts empty copy
Two copy fixes in
apps/mobile/src/i18n/locales/en.json(en only; the other 86 catalogs keep the previous wording until the next translation pass syncs them, per the repo flow of never hand-editing non-English catalogs):securityAgent.scopeEntry.reauthorizeDescriptionno longer quotes the raw GitHub permission identifier. It now reads: "Security Agent needs permission to read Dependabot alerts. Re-authorize the GitHub App to grant this permission."trustedHosts.emptyDescriptionnow covers both allowlists the screen shows when both are empty. It now reads: "When you trust a link's host or an image host, it opens without asking again." The screen (apps/mobile/src/components/trusted-hosts-screen.tsx) renders this empty state only when both the trusted link hosts and trusted image hosts lists are empty.Verification
pnpm check:i18nfromapps/mobile: 87 languages, every catalog matches en.json; no duplicate-copy or wording violations.pnpm typecheckinapps/mobile(after building@kilocode/harness-sdkand@kilocode/trpc): clean. The earlier ~1100 phantom errors were missing package builds, not change-related.pnpm lintinapps/mobile: 0 warnings, 0 errors.pnpm format: no diffs.omp36, Android 16, dev client on Metro from this branch, local backend): signed in with a fake account through the app's own OTP flow, then drove both surfaces:Proxy answers
Answer: Needs permission to read Dependabot alerts
Confidence: 0.60 · Precedent: UX and design quality: remove redundant copy and make surfaces clear (session a247f3c19b1e, "remove the redundant 'context' copy"); the brief asks for user words such as 'permission to read Dependabot alerts'
Answer: One sentence, both kinds
Confidence: 0.70 · Precedent: UX and design quality: remove redundant copy (session a247f3c19b1e, owner asked to remove the redundant "context" copy); the two-sentence option repeats the title
Answer: en.json only (Recommended)
Confidence: 0.75 · Precedent: Git and pull requests: never hand-edit generated files and keep the diff to needed files (session df491946927a, "PR should be checked for stray changes before merging"); the brief says en.json only and to regenerate through the repo flow