Skip to content

fix(mobile): correct Hungarian agent chat, session list and common copy - #8185

Merged
iscekic merged 2 commits into
mainfrom
drain/hu-mobile-copy
Oct 21, 2026
Merged

iscekic merged 2 commits into
mainfrom
drain/hu-mobile-copy

Conversation

@iscekic

@iscekic iscekic commented Oct 19, 2026

Copy link
Copy Markdown
Collaborator

Summary

Corrects 22 reviewed Hungarian (hu) copy findings in the mobile agent chat, session list and shared common strings, plus the start-agent repository wording on the same flow. Values only: no key, placeholder, plural category or English source change.

  • Agent chat: permission card "Mindig engedélyezés" (parallel to "Egyszeri engedélyezés"); PR badge states "nyitott PR" / "PR-piszkozat"; neutral needs-input title "Az ügynök válaszra vagy jóváhagyásra vár" (reused as the notification body for question and permission raises); repo picker and new-session repository copy aligned to the catalog-wide "adattár"; "Frissítve: {{time}}" for the diff timestamp; task progress accessibility "Feladatok: {{completed}}/{{total}} kész" without a suffix glued to the number.
  • Session list: in-progress "Keresés folyamatban"; placeholder "Munkamenetek keresése…"; no trailing full stop on the three short failure labels; "cent" for the singular spoken cost; "forrás: {{platform}}" origin phrase; "Nem sikerült másolni a munkamenet-azonosítót" with the catalog's hyphenated compound.
  • Common: "PR", "Platform", "Reakciók", and no trailing full stop on notFound / imageUnavailable.
  • Start agent: brand kept as "Kilo" ("a Kiloban") and lowercase "az ügynök indítása"; camera permission uses "Fotó" like the rest of the picker; attachment accessibility label is value-agnostic ("{{filename}}, {{status}}").

tools/i18n/wording-exceptions.json gains "search sessions" for hu: the input placeholder now carries the prompt ellipsis the English source has, while the accessibility label stays unpunctuated, and the checker folds the two English strings into one wording group.

Verification

  • pnpm --filter kilo-app check:i18n — 0 lint problems, check-catalogs: 87 languages, every catalog matches en.json.
  • pnpm --filter kilo-app check:plurals — every counted message declares its plural categories.
  • pnpm --filter kilo-app format:check and oxfmt --list-different tools/i18n/wording-exceptions.json — no differences.
  • pnpm --filter kilo-app exec vitest run src/i18n — 16 files, 1609 tests passed.
  • Affected component suites: permission card, question card, question card actions, platform filter, session row accessibility label, PR badge, session list search header / refresh status / body empty / screen — 207 tests passed.
  • Throwaway runtime smoke (deleted before commit): loaded the app i18n, switched to hu, resolved every changed key with its placeholders, and drove the real consumers — describePrBadge returned "nyitott PR Revert "Default Opus output effort to medium" #123" / "PR-piszkozat App Builder - Unit and Integration tests #7"; sessionRowAccessibilityLabel returned "Javítsd a bejelentkezést, CLOUD AGENT és forrás: GITHUB"; formatSpokenCost returned "1 cent" and "2 cent".

No screenshot: this is a values-only catalog change and the affected strings render behind authenticated agent-chat and session screens, so the runtime consumer assertions above are the exercised evidence.

Proxy answers

The owner's proxy gave these answers in the owner's place.

  1. Question: Ellipsis: The checker folds trailing ASCII dots but not '…', and the hu label/placeholder pair must render one wording. How should agents.search.searchSessionsPlaceholder keep its prompt ellipsis?
    Answer: Use '…' and add a hu wording exception
    Confidence: 0.55 · Precedent: Fix the root cause and the class: the brief asks for the '…' value, and the checker's sanctioned route is the exception list. This is a one-line, file-scoped addition. Session 7f3470e0ba6f: "fix class of issue preventing progress".
  2. Question: Repo term scope: The brief scopes the 'adattár' alignment to the agentChat.repoPicker sheet. The same start-agent screen's agentChat.newSession.* strings use 'tároló' (e.g. 'Válassz egy tárolót az indításhoz.'). Align those too?
    Answer: Also align agentChat.newSession.*
    Confidence: 0.60 · Precedent: If you see a gap, fix it, and fix the class on every affected surface. Session 89824a222897: "if you saw a gap, fix it". Skip any newSession keys owned by ledger item w14.
  3. Question: Needs-input title: agentChat.questionCard.title is reused as the needs-input notification body for both question and permission raises. Which neutral Hungarian title?
    Answer: Az ügynök válaszra vagy jóváhagyásra vár
    Confidence: 0.70 · Precedent: none
  4. Question: Origin phrase: agents.sessionRow.fromPlatform is joined into a spoken list (title, time, origin). Which replacement for 'innen: {{platform}}'?
    Answer: forrás: {{platform}}
    Confidence: 0.75 · Precedent: none
  5. Question: Always-allow CTA: Which Hungarian wording for the permission card's persistent allow button and its accessibility label?
    Answer: Mindig engedélyezés
    Confidence: 0.60 · Precedent: none

@iscekic iscekic added drain Work item from the findings drain janitor:i18n Janitor finding: mobile copy and catalog checks labels Oct 19, 2026
@kilo-code-bot

kilo-code-bot Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

The diff is a values-only Hungarian copy update in the mobile i18n catalogs; every changed entry preserves its placeholders and plural categories, stays valid JSON, and the added search sessions wording exception matches the checker's folded English source, so no correctness or runtime issue was found.

Files Reviewed (2 files)
  • apps/mobile/src/i18n/locales/hu.json
  • tools/i18n/wording-exceptions.json

Reviewed by deepseek-v4.1-flash-1017 · Input: 57.9K · Output: 13.9K · Cached: 743.9K

Review guidance: REVIEW.md from base branch main

@iscekic iscekic added merge:human Substantive functional risk requires human review. merge:bot Bot-owned review; merge when ready once readiness passes and a review approves. and removed merge:human Substantive functional risk requires human review. labels Oct 19, 2026
# Conflicts:
#	apps/mobile/src/i18n/locales/hu.json
#	tools/i18n/wording-exceptions.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

drain Work item from the findings drain janitor:i18n Janitor finding: mobile copy and catalog checks merge:bot Bot-owned review; merge when ready once readiness passes and a review approves.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants