Repository navigation
Conversation
…urface PRs Surface: the docs sync GitHub Action (`.github/docs-sync/**`). Update the body of PR #14085 and nothing else. Change no source file unless a test change is needed to produce the proof. Two gaps in that PR body: 1. The PR deletes `patches/ghostty-web@0.3.0.patch` and reorders the `trustedDependencies` and `patchedDependencies` lists in `bun.lock`, and the body does not say why. The reason: no dependency is patched with ghostty-web, so `bun install` prunes the orphan patch file and rewrites those lists in its own order. Add two lines to the body that state this. Do NOT restore the file and do not revert the lockfile. 2. The body says "No live proof applies" and leaves an owner verification item asking a person to dispatch the workflow. That is wrong twice: the owner must never be handed work the workflow can do, and this action IS provable offline. Run `.github/docs-sync/selftest.mjs` against a fixture change set that spans two product surfaces plus one unmapped file, and capture its real output. Put that output in the body as the proof, showing: the computed surface map, the two assignees chosen per surface, the reviewers requested, and the title of each pull request the run would open. Then remove the owner verification item. Rules: open no real pull request, request review from no real person, and call no live GitHub write API while proving it. The proof must be the selftest's own output, quoted, not a description of it.
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 files)
Reviewed by deepseek-v4.1-flash · Input: 0 · Output: 0 · Cached: 0 Review guidance: REVIEW.md from base branch |
Collaborator
Author
iscekic
force-pushed
the
kwf/docs-sync-surface-prs-34e3
branch
from
September 13, 2026 15:58
64df058 to
68567d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog for users
otherpull request, instead of a single rolling pull request.otherpull request uses lambertjosh and intentionally-left-nil.other, and how its reviewers were computed.workflow_dispatchdry run still collects and triages and opens no pull request.Changelog for maintainers
patches/ghostty-web@0.3.0.patch: no dependency in the tree is patched with ghostty-web, sobun installprunes the orphan patch file.trustedDependenciesandpatchedDependencieslists inbun.lockare reordered becausebun installrewrites those lists in its own order; the dependency set is unchanged.surfaces.jsonis the committed surface map (cli, vscode, jetbrains, gateway, web, plusother), and a path resolves to exactly one surface by longest prefix match;upsert-pr.mjsrebuilds each surface branch in a throwaway worktree so a doc file lands in exactly one pull request and human commits survive;prepare-branch.mjskeepsdocs/auto-syncas the integration base and pushes the tree to the sibling refdocs/auto-sync-integration;reviewers.mjsranks contributors with a 180-day half-life and drops bots and non-writers, replacingDOCS_OWNER;lib.mjsexportsREASONING_VARIANT, the workflow cites the Kilo gateway DeepSeek id with--variant maxat everykilo runcall site, andmodel-config.test.mjsplussurfaces.test.mjscover the wiring, with the selftest job running every.github/docs-sync/*.test.mjs..github/docs-sync/upsert-pr.mjs:460— accepted and fixed:git checkoutcannot apply a deletion, so the branch runsgit rm -rf --ignore-unmatchon the deleted paths first and then restores the rest from the integration tree; selftest case 16 covers a deletion and an added page landing on the same surface branch..github/docs-sync/reviewers.mjs:124— rejected, no change: a failed permission lookup is caught and degrades to the documented explanatory note, so it never assigns a wrong person..github/docs-sync/prepare-branch.mjs:211— rejected, no change: the stale remote-tracking ref must be removed for the surface branches to coexist withdocs/auto-sync, and the cleanup only warns when it fails..github/docs-sync/reviewers.mjs:109— rejected, no change: the commit mapping skips a commit with no linked GitHub account, which is the intended reviewer-candidate behavior..github/docs-sync/upsert-pr.mjs:580— accepted:learn.mjslearns corrections from every open surface pull request, not just the first, and patches each pull request's learned-through marker; case 17 covers it..github/docs-sync/upsert-pr.mjs:695— accepted: a skipped surface refreshes its open pull request's processed-through marker, and the watermark comes from the most recently updated pull request; cases 19-20 cover it..github/docs-sync/prepare-branch.mjs:203— accepted: the legacydocs/auto-syncbranch is deleted whenever it exists, not only when an open legacy pull request exists; case 18 covers it.E2E proof
Offline proof, the action's own selftest:
node .github/docs-sync/selftest.mjs, case 21. A fixture change set spanning two product surfaces (cli,vscode) plus one unmapped file produces exactly three pull requests, one per surface, each carrying only its own changed file. The command opens no pull request and calls no live GitHub write API: every create, assignee call and review request below was captured from the action's own requests to a local stub. Raw output:node .github/docs-sync/selftest.mjsends withselftest: all cases passed. There is no owner manual check for this change.Owner request
Owner request