Skip to content

docs(migration): refresh the v2 baseline at v2.0.30 - #15192

Merged
fpliger merged 2 commits into
fold-plan-deltafrom
refresh-v2-baseline
Oct 17, 2026
Merged

fpliger merged 2 commits into
fold-plan-deltafrom
refresh-v2-baseline

Conversation

@fpliger

@fpliger fpliger commented Oct 17, 2026 •

Copy link
Copy Markdown

Stacked on #15191 (then #15190, then #15189). This re-measures pinned-v2-baseline.md at the current base, because the base now moves with every sync.

What was measured

  • origin/v2 98ead1f27e, synced to upstream v2.0.30 (775d1d0d713, chore(upstream): sync v2.0.30 (775d1d0d713) #15136).
  • Clean detached worktree, the same host as the 2026-10-11 capture, isolated OPENCODE_TEST_HOME and XDG_*.
  • Sequence: install, typecheck --force, lint, the effect lints, turbo test --continue --force, the three check:generated commands, CLI build, service smoke.
Check 2026-10-11 (initial base) 2026-10-16 (v2.0.30)
typecheck pass 36/36 pass 27/27, includes both Kilo packages
lint pass (1,509 warnings) pass (oxlint only since #15151, 214 warnings)
lint:effect-patterns 27 errors 27 errors
turbo test core 30 fail core 37, cli 1, tui 1 fail. 30 are the same host cases (bash 3.2, no rg). The other 9 time out under full parallel load and pass in an isolated re-run (flock, config instruction, cli import-export, tui diff-viewer)
protocol check:generated stale pass
CLI build and service smoke pass pass
Kilo packages none gateway-core 36 pass, kilo-plugin 1 pass

File changes

  • technical-notes/baseline/pinned-v2-baseline.md
    • New "Current capture" section: refs, results, current reds, Kilo packages.
    • The validation-commands section is updated: lint is oxlint only, and the fork CI triggers are described as they are in this tree (second commit, after the review bot flagged the first version).
    • The 2026-10-11 capture is kept unchanged as "Previous capture" (headings demoted). It is evidence, not rewritten.
  • .kilo/skills/v2-migration/SKILL.md and plan A4: the baseline is re-measured after each sync and names its release. When v2 has moved past that release, compare against origin/v2.
  • plans/migration-context.md, bootstrap status: baseline "refreshed 2026-10-16 at v2.0.30".

Limits

  • Node build and smoke were not run (this host has Node 24, CI pins 26.4.0).
  • Host-environment reds are macOS-only and green on Linux CI.

@github-actions

github-actions Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

➖ v2 migration progress: 0.1% → 0.1% (0 done, 0 total, 0 dropped; 12/9854 cells)

No change to the progress map.

v2 migration progress map at this commit

Full map · how cells close

- Tests cannot run from the root (`bunfig.toml` test root `do-not-run-tests-from-root`). Run them from a package directory or through turbo.
- Never run `tsc`. Packages use `tsgo` through `bun typecheck`.
- `.husky/pre-push` checks the bun version, then runs `bun run check`.
- `check.yml` runs on pushes to any branch named `dev` or `v2`, and on pull requests whose base branch has one of those names. Upstream wrote it for `upstream/dev` and `upstream/v2`. `test.yml` runs on every `pull_request`. **Changed 2026-10-12:** the Kilo integration branch was renamed to `v2`, so upstream's `check.yml` triggers now match pushes to `origin/v2` and pull requests that target it. **Verified 2026-10-16:** `check.yml` (`typecheck`) and `test.yml` (`unit`, `e2e`) run on the fork for pushes to `origin/v2` and pull requests that target it, next to Kilo's `kilo-v2.yml`; see the current capture. The 2026-10-11 capture had found no pull request targeting the integration branch or `kilo-v2-clean-bootstrap` (`gh pr list`).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SUGGESTION: The trigger description does not match check.yml in this tree.

check.yml declares pull_request: with no branches filter; the kilocode_change at .github/workflows/check.yml:6 runs it "for every pull request, so Kilo v2 PRs (which target v2 or a stacked PR branch) are checked". test.yml has the same unfiltered pull_request:. So "and on pull requests whose base branch has one of those names" is inaccurate for the fork (and its script/upstream/shared-patches.json entry) - this PR (base fold-plan-delta) is checked under the unfiltered trigger. Since this bullet is being rewritten to record verification, consider saying check.yml and test.yml run on every pull request (upstream's base-branch filter was removed for stacked PRs).


Reply with @kilocode-bot fix it to have Kilo Code address this issue.

@kilo-code-bot

kilo-code-bot Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

The previous SUGGESTION on pinned-v2-baseline.md:76 is resolved: the rewritten bullet now states that check.yml and test.yml run on pushes to dev/v2 and on every pull request, matching the unfiltered pull_request: in this tree (.github/workflows/check.yml:5-7, .github/workflows/test.yml:7). The refresh also correctly records affected as if: false (.github/workflows/test.yml:27).

Files Reviewed (4 files)
  • .kilo/skills/v2-migration/SKILL.md - no issues
  • migration-tracking/plans/kilo-v2-migration-plan.md - no issues
  • migration-tracking/plans/migration-context.md - no issues
  • migration-tracking/technical-notes/baseline/pinned-v2-baseline.md - no issues
Previous Review Summary (commit a9ddf5d)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit a9ddf5d)

Status: 1 Issue Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 0
SUGGESTION 1
Issue Details (click to expand)

SUGGESTION

File Line Issue
migration-tracking/technical-notes/baseline/pinned-v2-baseline.md 76 The rewritten check.yml trigger bullet still says CI runs "on pull requests whose base branch has one of those names", but this tree's check.yml and test.yml both use an unfiltered pull_request: (see the kilocode_change at .github/workflows/check.yml:6 and the check.yml entry in script/upstream/shared-patches.json), so every pull request is checked - including this one, which targets fold-plan-delta.
Files Reviewed (4 files)
  • .kilo/skills/v2-migration/SKILL.md - no issues
  • migration-tracking/plans/kilo-v2-migration-plan.md - no issues
  • migration-tracking/plans/migration-context.md - no issues
  • migration-tracking/technical-notes/baseline/pinned-v2-baseline.md - 1 issue

Verified against the tree: the measured ref 98ead1f27e exists and is an ancestor of HEAD with subject Merge pull request #15178; 775d1d0d713 is its ancestor and packages/cli at that commit is 2.0.29; check-shared-patches.json sets files: 14; root lint is oxlint and check is lint && typecheck; packages/protocol and services/www both define check:generated; the referenced ConfigInstructionPlugin.Plugin > reloads configured sources... test exists in packages/core/test/instruction-discovery.test.ts:365. The reds arithmetic is internally consistent (30 host-environment + 9 load flakes = 39 fails). upstream/dev at 07bbd0fd166 is not present locally (fetch-only remote), so that row was not independently checked.

Fix these issues in Kilo Cloud


Reviewed by deepseek-v4.1-flash · Input: 37.4K · Output: 3.8K · Cached: 246.5K

Review guidance: REVIEW.md from base branch fold-plan-delta

@fpliger
fpliger merged commit ed35189 into fold-plan-delta Oct 17, 2026
14 checks passed
@fpliger
fpliger deleted the refresh-v2-baseline branch October 17, 2026 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant