Repository navigation
docs(migration): refresh the v2 baseline at v2.0.30 - #15192
Conversation
|
➖ v2 migration progress: 0.1% → 0.1% (0 done, 0 total, 0 dropped; 12/9854 cells) No change to the progress map. |
| - Tests cannot run from the root (`bunfig.toml` test root `do-not-run-tests-from-root`). Run them from a package directory or through turbo. | ||
| - Never run `tsc`. Packages use `tsgo` through `bun typecheck`. | ||
| - `.husky/pre-push` checks the bun version, then runs `bun run check`. | ||
| - `check.yml` runs on pushes to any branch named `dev` or `v2`, and on pull requests whose base branch has one of those names. Upstream wrote it for `upstream/dev` and `upstream/v2`. `test.yml` runs on every `pull_request`. **Changed 2026-10-12:** the Kilo integration branch was renamed to `v2`, so upstream's `check.yml` triggers now match pushes to `origin/v2` and pull requests that target it. **Verified 2026-10-16:** `check.yml` (`typecheck`) and `test.yml` (`unit`, `e2e`) run on the fork for pushes to `origin/v2` and pull requests that target it, next to Kilo's `kilo-v2.yml`; see the current capture. The 2026-10-11 capture had found no pull request targeting the integration branch or `kilo-v2-clean-bootstrap` (`gh pr list`). |
There was a problem hiding this comment.
SUGGESTION: The trigger description does not match check.yml in this tree.
check.yml declares pull_request: with no branches filter; the kilocode_change at .github/workflows/check.yml:6 runs it "for every pull request, so Kilo v2 PRs (which target v2 or a stacked PR branch) are checked". test.yml has the same unfiltered pull_request:. So "and on pull requests whose base branch has one of those names" is inaccurate for the fork (and its script/upstream/shared-patches.json entry) - this PR (base fold-plan-delta) is checked under the unfiltered trigger. Since this bullet is being rewritten to record verification, consider saying check.yml and test.yml run on every pull request (upstream's base-branch filter was removed for stacked PRs).
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
Code Review SummaryStatus: No Issues Found | Recommendation: Merge The previous SUGGESTION on Files Reviewed (4 files)
Previous Review Summary (commit a9ddf5d)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit a9ddf5d)Status: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (4 files)
Verified against the tree: the measured ref Reviewed by deepseek-v4.1-flash · Input: 37.4K · Output: 3.8K · Cached: 246.5K Review guidance: REVIEW.md from base branch |
Stacked on #15191 (then #15190, then #15189). This re-measures
pinned-v2-baseline.mdat the current base, because the base now moves with every sync.What was measured
origin/v298ead1f27e, synced to upstreamv2.0.30(775d1d0d713, chore(upstream): sync v2.0.30 (775d1d0d713) #15136).OPENCODE_TEST_HOMEandXDG_*.--force, lint, the effect lints, turbo test--continue --force, the threecheck:generatedcommands, CLI build, service smoke.v2.0.30)oxlintonly since #15151, 214 warnings)lint:effect-patternsrg). The other 9 time out under full parallel load and pass in an isolated re-run (flock, config instruction, cli import-export, tui diff-viewer)check:generatedgateway-core36 pass,kilo-plugin1 passcheck.ymlandtest.ymlrun on pushes todevorv2and on every pull request, including PRs into stacked branches (Kilo made thecheck.ymlPR trigger unfiltered in chore(v2): land CI lane, isolated bun dev and migration skill #15016; this PR'stypecheckran with basefold-plan-delta).kilo-v2.ymlruns alongside. This closes the UNVERIFIED follow-up in the file.e2eis skipped on the fork since chore: remove upstream desktop, web app and hosted platform packages #15151; it last ran on chore(upstream): sync v2.0.30 (775d1d0d713) #15136, where Windows failed.v2.0.31,v2.0.32), 1 day.File changes
technical-notes/baseline/pinned-v2-baseline.mdoxlintonly, and the fork CI triggers are described as they are in this tree (second commit, after the review bot flagged the first version)..kilo/skills/v2-migration/SKILL.mdand plan A4: the baseline is re-measured after each sync and names its release. Whenv2has moved past that release, compare againstorigin/v2.plans/migration-context.md, bootstrap status: baseline "refreshed 2026-10-16 atv2.0.30".Limits