Repository navigation
docs(migration): record the host strategy and add the feature placement skill - #15228
Conversation
|
➖ v2 migration progress: 0.1% → 0.1% (0 done, 0 total, 0 dropped; 12/9854 cells) No change to the progress map. |
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Incremental review of
No runtime code, no shared upstream files, no generated client files, no Files Reviewed (1 file)
Previous Review Summary (commit ea58ef5)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit ea58ef5)Status: 2 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (6 files)
Docs-only PR: no shared upstream files, no Reviewed by deepseek-v4.1-flash-1017 · Input: 59.3K · Output: 62.8K · Cached: 1.8M Review guidance: REVIEW.md from base branch |
Part of #15171 (foundation) and #13750.
What Problem This Solves
The plan now says plugin first, Q-HOST-01 is answered (#15223) and U-E0-01 has an issue (#15172), but the reasoning behind the host, the measured history it rests on, the guarantees it must hold when upstream changes again, and the procedure an agent follows to place one change are not written anywhere. Each new unit re-derives them, and the vocabulary (hook, seam, patch) is used inconsistently, including in the progress map.
Why This Change Was Made
migration-tracking/plans/v2-host-strategy.md(new, living): the measured lessons from the v1 merges and from the v1 to v2 rewrite, the rejected approaches, the four-layer target shape and dependency direction, the host as the first step with its pieces and seams measured atv2.0.30, the three placement cases with worked examples and shape rules, the guarantees under four upstream futures and the three rules that enforce them, the three change detectors that replace the merge conflict as a signal, what changes in the progress map, the order of work, and the open decisions (facade, owners, binary name, TUI plugin registration)..kilo/skills/v2-feature-placement/SKILL.md(new): the procedure for one change. Vocabulary, the rung decision with thergcommands that find a plugin hook or a replaceable service node, seam and patch shape rules, the import rules for logic packages and adapters, the done-proof for the progress map (kilocode_change(<feature>:<id>)in shared files,kilo_port(<feature>:<id>)in Kilo-owned files), the verification commands, and the PR placement statement..kilo/skills/v2-migration/SKILL.md: loads the placement skill before placing a change; the progress-map rule now covers Kilo-owned files.v2-fork-conventions.md: vocabulary paragraph under "Plugin-first extension order" and links to the skill and the strategy.kilo-v2-migration-plan.md: the U-E0-01 row links the measured pieces.migration-tracking/README.md: start-here row.User Impact
Docs and agent instructions only. No runtime change.
Evidence
bun script/check-shared-patches.ts: ok.bun script/upstream/progress.ts --check: up to date. The new files contain no em dashes.bbbeb8e6307:SdkPlugins.registertyping (core/src/plugin/sdk.ts),createRoutes(overrides)(server/src/routes.ts:81-84) versusServerProcess.startwithout overrides (server/src/process.ts:47),cli/package.jsonexports, the Gateway adapter's 12 upstream imports, the compaction constant (session/compaction.ts:100), the tool editor and hooks (plugin/src/effect/tool.ts), the v2.0.30 dependency diff of the Gateway adapter (3 of 12 modules changed, no conflict).