Repository navigation
docs(migration): add the rules to verify and close progress map cells - #15239
Conversation
|
➖ v2 migration progress: 0.9% → 0.9% (0 done, 0 total, 0 dropped; 86/9829 cells) Placement: 0 new marked lines in shared files, 0 new Ratchets: 8 core-internal imports (base 8); shared patches by rung 16 seam, 1 patch (base 16 seam, 1 patch). No change to the progress map. |
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Incremental review of The regenerated history now matches Files Reviewed (4 files)
Note: review was read-only, so the generator was not executed; the history values were verified against the committed Previous Review Summaries (2 snapshots, latest commit d754045)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit d754045)Status: No Issues Found | Recommendation: Merge Incremental review of Files Reviewed (4 files)
Note: review was read-only, so the generator was not executed; the README and generator sources are unchanged since the previous review and still agree. Previous review (commit af7ebd2)Status: No Issues Found | Recommendation: Merge Documentation-only change. Every new rule was checked against Files Reviewed (4 files)
Note: review was read-only, so Reviewed by deepseek-v4.1-flash-1017 · Input: 54.4K · Output: 11.2K · Cached: 688.3K Review guidance: REVIEW.md from base branch |
# Conflicts: # .kilo/skills/v2-migration/SKILL.md
What Problem This Solves
The migration skills told agents which done-proof to write, but not how to decide that a cell is done. In the Gateway port (#15237) a given classification would have closed cells with real gaps:
nativefor request defaults that v2 does not send,droppedfor cloud session import and the event service client (both have plan units), andportedfor modules whose v2 code lacks part of the behavior.Why This Change Was Made
The rules now sit where agents read them before and during a port:
.kilo/skills/v2-migration/SKILL.md, section "Progress map": an ordered choice of proof (marker,kilo_port, v1 file name,ported,native,facade,dropped), and a verification list: compare behavior by behavior, find v1 callers,droppedonly for behavior that is not carried (never for behavior a plan unit still ports), no closing with a known gap, mixed hunks, test cells, claims in tasks or plans are verified,git addbefore regenerating, regenerate twice and--check, a reason for each open cell..kilo/skills/v2-feature-placement/SKILL.md, step 7: the same choice in short form, with the commands, and a pointer to the full rules..kilo/skills/v2-migration/SKILL.md, section "Evidence": every PR that changes the map gets a## Progress mapsection with the box before and after, and one short line per cell or group on why it is done, why it is dropped (what it did on v1, why v2 does not need it, the evidence), and why it stays open (what is missing, which unit owns it), plus corrections to a given classification.v2-feature-placementstep 8 points to it.script/upstream/progress.ts: one counting rule in the generatedmigration-tracking/progress/README.mdthat says what a proof claims and whendroppedapplies.User Impact
None at runtime. Future ports close progress map cells by the same rules.
Evidence
bun script/upstream/progress.tstwice with identical output, then--check: up to date. The map numbers do not change.This PR and #15237 both regenerate
migration-tracking/progress/README.md. The second one to merge regenerates it.