Skip to content

docs(migration): document the block marker form in the strategy and placement skill - #15269

Merged
fpliger merged 1 commit into
v2from
coord-plan-marker-form
Oct 20, 2026
Merged

fpliger merged 1 commit into
v2from
coord-plan-marker-form

Conversation

@fpliger

@fpliger fpliger commented Oct 20, 2026

Copy link
Copy Markdown

Coordinator plan micro-PR. Documents the block marker form in migration-tracking/plans/v2-host-strategy.md §5 and .kilo/skills/v2-feature-placement/SKILL.md (steps 4 and 5).

#15259 found that the shared-patch counters recognize a block only when start or end follows kilocode_change directly (script/upstream/utils/shared.ts, utils/markers.ts). A block written as kilocode_change(<feature>) start breaks the count: check-shared-patches counted 2 marked and 9 unmarked lines for the AGENTS.md block and failed. The fork conventions already record this. The strategy and the placement skill only showed the single-line tagged form, so an author who followed the skill could write a block that breaks the count.

File Change
v2-host-strategy.md §5 Block form kilocode_change start - <feature>: <reason> ... kilocode_change end, the reason, and where a <feature>:<id> done-proof goes inside a block
v2-feature-placement/SKILL.md step 4 (seam) Block form for a seam longer than one line, and the form to avoid
v2-feature-placement/SKILL.md step 5 (patch) Block form for a fix that needs more than one line, and where the proof goes

No rule changes; this documents what the tooling already requires. Checks: bun script/upstream/progress.ts --check reports the map is up to date. No Changeset.

@github-actions

Copy link
Copy Markdown
Contributor

➖ v2 migration progress: 0.9% → 0.9% (0 done, 0 total, 0 dropped; 86/9829 cells)

Placement: 0 new marked lines in shared files, 0 new kilo_port annotations, 0 new core-internal imports.

Ratchets: 9 core-internal imports (base 9); shared patches by rung 28 seam, 2 patch (base 28 seam, 2 patch).

No change to the progress map.

v2 migration progress map at this commit

Full map · how cells close

@kilo-code-bot

kilo-code-bot Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

The change documents the already-enforced block marker form: start/end must follow kilocode_change directly. I verified the claim against script/upstream/utils/shared.ts:139-140 (START/END use \s+start/\s+end) and script/upstream/utils/markers.ts:55-56, matching v2-fork-conventions.md. The recommended forms (kilocode_change start - <feature>: <reason> ... kilocode_change end) are recognized, and the form called out as broken (kilocode_change(<feature>) start) does not match either regex. A done-proof inside a block is still found by progress.ts (script/upstream/progress.ts:62) and covered by coveredLines. Both touched paths are Kilo-owned, so no markers or shared-patch changes are needed. No images or code changes, so the landing-page image rule and memory-leak focus do not apply.

Files Reviewed (2 files)
  • .kilo/skills/v2-feature-placement/SKILL.md - 0 issues
  • migration-tracking/plans/v2-host-strategy.md - 0 issues

Reviewed by deepseek-v4.1-flash-1017 · Input: 150.3K · Output: 18.4K · Cached: 1.2M

Review guidance: REVIEW.md from base branch v2

@fpliger
fpliger merged commit 71124f0 into v2 Oct 20, 2026
23 checks passed
@fpliger
fpliger deleted the coord-plan-marker-form branch October 20, 2026 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant