Repository navigation
refactor(app): render money and time only through the shared components - #48
Open
jdjioe5-cpu wants to merge 1 commit into
Open
jdjioe5-cpu wants to merge 1 commit into
jdjioe5-cpu wants to merge 1 commit into
Conversation
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #40
Routes every in-scope money and time display through the shared components (`AmountDisplay`, `AssetLabel`, `DateTimeDisplay`) and introduces a static guard test to ensure zero regressions:
1. Pre-change Inventory
2. In-Scope Replacements
3. Out-of-Scope Money-Action Routes
As required by issue guidelines and Hard Rule 5, the money-action routes remain untouched and left for maintainer handling:
Accordingly, roadmap row `M3-15` remains IN PROGRESS with changelog updated.
Hard rules touched
Verify output
```bash
$ pnpm lint
Checked 84 files in 20ms. No fixes applied.
$ pnpm typecheck
tsc --noEmit (exited with 0)
$ pnpm test
Test Files 16 passed (16)
Tests 209 passed (209)
Start at 19:42:46
Duration 767ms
$ pnpm build
▲ Next.js 16.3.8 (Turbopack)
✓ Compiled successfully in 905ms
✓ Generating static pages using 14 workers (6/6) in 417ms
```