Repository navigation
feat(app): /attester read-only payout-account checks - #50
Open
jdjioe5-cpu wants to merge 1 commit into
Open
jdjioe5-cpu wants to merge 1 commit into
jdjioe5-cpu wants to merge 1 commit into
Conversation
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Closes #42.
Replaces the
/attesterplaceholder stub with a fully functioning, read-only payout-account verification page. Attesters can verify institutional payout accounts before onboarding or publishing registry records, strictly matching the verdicts ofkinlock-registry/scripts/check-attester-readiness.tswithout asking for secret keys, seed phrases, or transaction signatures.Changes
lib/attester/strkey.ts(new): RFC 4648 Base32 + CRC-16 XModem validator for Stellar Ed25519 public keys (G-addresses). Pre-validates user inputs before any network calls, rejecting invalid prefixes, short inputs, and corrupted checksums.lib/attester/readiness.ts(new): Core evaluation engine that categorizes Horizon accounts into three explicit verdicts:account.exists);absent) vs unapproved (unauthorised) vs full limit (no_room) vsauthorisedwith room, showing the asset code and configured issuer.app/attester/useAttesterChecker.ts&AttesterChecker.tsx(new): Client component and decoupled state hook with loading states,role="status", WCAG AA contrast, and zero inline strings.app/attester/page.tsx: ReplacedPageStubwithAttesterChecker, configured withexport const dynamic = "force-dynamic".messages/en.json: Added all user-visible strings underpages.attester.*.README.md&ROADMAP.md: Documented/attesterin the routes table, advancedM3-12toDONE, and added Changelog entry.Hard rules / invariants touched
Tests
Added
lib/attester/readiness.test.tswith 7 test cases covering all verdict branches against Horizon fixtures.Ran all verification commands cleanly:
Side-by-Side Parity Evidence against
check-attester-readiness.tsGCLMHF7LAR34TSELDNEREYPTNE4K7MMESPS62WXE7ZDLPWIJUF3MC5QM):check-attester-readiness.ts:/attesterReadiness Report:pass(exists on testnet)pass(9999.9647224 XLM >= 2 XLM)pass(authorisedwith room)0GCC7BYEDK2RJKHKRRY6QVEUYNRBAYRCTU76MQFPUGD7D3AO6G5XITMPJ):check-attester-readiness.ts:/attesterReadiness Report:fail(does not exist on testnet)nullfail(absent)2Docs / ADR
README.mdROADMAP.md(M3-12->DONE)Roadmap
M3-12markedDONEAssumptions and open questions
None.