feat(segments): add segment locking with paint protection - #760
Merged
Conversation
✅ Deploy Preview for volview-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
PaulHax
reviewed
Jul 3, 2025
PaulHax
left a comment
PaulHax
left a comment
Collaborator
There was a problem hiding this comment.
Really awesome addition!
Would you be up for making this lock feature work for the processing options (fill between and smooth)?
Contributor
Author
|
Thanks for the feedback! I have updated startProcess to check if the active segment is locked before processing, and added a check in doPaintStroke. |
Also ran `npm run prettify`
PaulHax
self-requested a review
July 8, 2025 15:53
PaulHax
approved these changes
Jul 8, 2025
PaulHax
left a comment
PaulHax
left a comment
Collaborator
There was a problem hiding this comment.
Thank you! I added another commit with more spacing between the toggle viz/lock buttons and ran npm run prettify
floryst
approved these changes
Jul 11, 2025
floryst
left a comment
floryst
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the feature addition!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds lock/unlock buttons to individual segments to prevent them from accidental modification when painting other segments.