Syntax error from long string inside table constructor brackets

[hugomg]

LuaFormatter version 1.3.6 produces invalid output if the input program contains a [[ string inside a [ ] = table constructor.

t = { [ [[abc]] ] = 1}

When we format this, the spaces are removed and the result is a syntax error

t = {[[[abc]]] = 1}

The good news is that LuaFormatter already does the right thing for array brackets such as xs[ [[abc]] ]. Perhaps whatever logic is being used there should also be used for table constructors.

[hugomg]

For reference, I think the parts responsible for writing arrays and fields are these ones:

LuaFormatter/src/visitor/var.cpp

Lines 54 to 70 in 29afe10

	// if table key is a nested string, keep the whitespace
	// example:
	// x = {}
	// x[ [[key]] ] = "value"
	if (!expString.empty() && expString[0] == '[') {
	cur_writer() << ctx->LSB()->getText();
	cur_writer() << commentAfter(ctx->LSB(), " ");
	visitExp(ctx->exp());
	cur_writer() << commentAfter(ctx->exp(), " ");
	cur_writer() << ctx->RSB()->getText();
	} else {
	cur_writer() << ctx->LSB()->getText();
	cur_writer() << commentAfter(ctx->LSB(), "");
	visitExp(ctx->exp());
	cur_writer() << commentAfter(ctx->exp(), "");
	cur_writer() << ctx->RSB()->getText();
	}

LuaFormatter/src/visitor/table.cpp

Lines 199 to 211 in 29afe10

	antlrcpp::Any FormatVisitor::visitField(LuaParser::FieldContext* ctx) {
	LOG_FUNCTION_BEGIN();
	std::string eq_space = config_.get<bool>("spaces_around_equals_in_field") ? " " : "";
	if (ctx->LSB() != nullptr) {
	cur_writer() << ctx->LSB()->getText();
	cur_writer() << commentAfter(ctx->LSB(), "");
	visitExp(ctx->exp()[0]);
	cur_writer() << commentAfter(ctx->exp()[0], "");
	cur_writer() << ctx->RSB()->getText();
	cur_writer() << commentAfter(ctx->RSB(), eq_space);
	cur_writer() << ctx->EQL()->getText();
	cur_writer() << commentAfter(ctx->EQL(), eq_space);
	visitExp(ctx->exp()[1]);