Skip to content

feat: add control_plane_id field to the dumped configuration - #303

Closed
asartori86 wants to merge 1 commit into
Kong:mainfrom
asartori86:feat/konnect-control-plane-id
Closed

feat: add control_plane_id field to the dumped configuration#303
asartori86 wants to merge 1 commit into
Kong:mainfrom
asartori86:feat/konnect-control-plane-id

Conversation

@asartori86

@asartori86 asartori86 commented Jun 27, 2025

Copy link
Copy Markdown
Collaborator

Summary

Add the field control_plane_id to the Konnect schema to support its usage via deck

Full changelog

  • Add the field control_plane_id to the Konnect schema to support its usage via deck

Issues resolved

n/a

Documentation

dependent PR

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

Add the `control_plane_id` field to enable its usage in `decK`.
@CLAassistant

CLAassistant commented Jun 27, 2025

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 28.52%. Comparing base (12b7e8c) to head (e1e5cfd).

Files with missing lines Patch % Lines
pkg/file/writer.go 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #303      +/-   ##
==========================================
- Coverage   28.52%   28.52%   -0.01%     
==========================================
  Files         117      117              
  Lines       18761    18764       +3     
==========================================
  Hits         5352     5352              
- Misses      12809    12811       +2     
- Partials      600      601       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GGabriele

Copy link
Copy Markdown
Collaborator

Hey @Prashansa-K can you please take a look?

@GGabriele
GGabriele requested a review from Prashansa-K July 3, 2025 06:43
GGabriele
GGabriele previously approved these changes Jul 3, 2025
@Prashansa-K

Copy link
Copy Markdown
Contributor

@asartori86 Could you reopen this PR, not from a fork, but directly a branch in the same repo? The enterprise test suite is skipped in this one due to the repository settings.

@Prashansa-K
Prashansa-K dismissed GGabriele’s stale review July 3, 2025 07:20

Dismissing this so that we can re-review once the enterprise test suite passes.

@asartori86

Copy link
Copy Markdown
Collaborator Author

sueperseded by #308

@asartori86 asartori86 closed this Jul 4, 2025
@asartori86

Copy link
Copy Markdown
Collaborator Author

@asartori86 Could you reopen this PR, not from a fork, but directly a branch in the same repo? The enterprise test suite is skipped in this one due to the repository settings.

@Prashansa-K done! please refer to #308 thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants