Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Restores the configured default image for coverless items in custom plugins.
Root cause
The custom plugin formatter historically turns an empty
cover_imageinto the generic DVinyl logo. Since the image gallery change, the shared formatter reads that value back as if it were a real item image, so it wins over the custom plugin placeholder after saving. The add-item preview is not affected because it reads the plugin placeholder directly.Fix
Ignore the generic and plugin-specific placeholders when building the list of actual item images. Real covers keep their priority, while a coverless item falls back to the plugin default at render time as intended. No data migration is needed.
Related issue
Fixes #154
Type of change
Checklist
make typecheckpassesScreenshots
Not applicable, there is no UI layout change.
Anything else?
Validation performed:
npx tsc --noEmit