Repository navigation
#52 Improve efficiency seqmetrics instability index - #55
Merged
Merged
Conversation
…ency-seqmetrics-instability-index Improve efficiency seqmetrics instability index
Owner
|
this PR refactors for better error handling and improves efficiency with changing String allocation to a tuple. All tests pass and produce the expected output locally |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve efficiency seqmetrics instability index
Context
Issue #52
Under
instability_indexfn there is a String allocation to look up the weights,This could be avoided by not constructing a string as a key for weight lookup and rely on tuple of chars
What changed ?
load_instability-> Replaced key from String to (char, char), along with validation errors since if the key is invalid it's better to fail than have invalid / incomplete hash map for lookupsinstability_index-> Removed format!() and replaced with (window[0], window[1]) for lookupTests