fix(keychain): customer QA fixes for SDK, passkey recovery and onboarding - #670
Merged
Merged
Conversation
added 9 commits
September 16, 2026 12:02
clawdbot-glitch003
marked this pull request as ready for review
September 16, 2026 19:53
Landing.tsx and AddSecret.tsx hard-coded `@lit-protocol/keychain@<version>` and had already drifted (2.0.2 vs 2.0.3). Read the version once from sdk/package.json via web/src/version.ts and add a docs test asserting every pin in the markdown guides, llms.txt and web sources equals that version. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Customer-path QA of https://keychain.litprotocol.com using public docs and published npm 2.0.2 first, followed by fixes. No real customer credentials, paid provider calls, attestation bypass or funded transactions.
/README.md; remove broken platform links; clarify export/get versus service/use, Supabase credential shape, MCP paths, credential exposure, attestation, rotations and write retries.Verified against production
Real virtual-CTAP2 passkey registration and existing-key login; dummy secret create/approve; attestation-enabled CLI/SDK/MCP retrieval; child environment/file handling and cleanup; denied unapproved agent; disable/enable; revoke/reapprove; rotation v2 with old config; permission renewal; backup-selected recovery using only the recovery passkey; execution-key replacement (old config 401, new config succeeds).
The fixed Node SDK also completed live attestation with all six checks, including
tls-certificate-in-tee. Production customer-path tests used published 2.0.2; local regression tests verify the candidate fixes, not their deployment.Local validation
npm test: 88 passed, 3 environment-dependent skips, 0 failures.Repeated GitHub first-test module-import failures led to replacing the Vite dev server with an isolated prebuilt UI/identity harness. No test retries or weakened assertions. Three cold starts and a CI-mode local run each passed all 10 passkey tests; the integrating reviewer independently reran all 10 successfully. Two new harness readiness/cleanup tests pass. Exact original optimizer race is not claimed proven. All GitHub checks passed on final commit
cc22df17a0909939947c03acc300363e9852f71f, including the complete Keychain job. Ready for review; not merged, deployed or published.Honest coverage limits
Provider success calls need disposable GitHub/Stripe/OpenAI/Slack/Supabase credentials. Google/wallet login, physical/cross-device passkeys, paid checkout/cancellation, over-limit billing, actual elapsed expiry and complete backend data-loss recovery remain unverified. Two intermittent production failures are recorded without unsupported root-cause claims. This is broad customer-path QA, not proof of exhaustive security coverage.
Detailed report: user-qa-2026-09-16.md. Private keys/configs/backups excluded.