Skip to content

Filter zero-variance groups after infra checks - #71

Merged
flukeskywalker merged 4 commits into
prodfrom
agent/filter-zero-variance-groups
Sep 8, 2026
Merged

flukeskywalker merged 4 commits into
prodfrom
agent/filter-zero-variance-groups

Conversation

@nightlessbaron

Copy link
Copy Markdown

Summary

  • reject all-correct and all-incorrect rollout groups after infra/abort validation
  • preserve the existing abort and infra-failure rejection precedence
  • cover every configured infra status plus nested, mixed, and zero-variance groups

Dependency

This is stacked on #60 and therefore temporarily includes #60's commits in the prod diff. Rebase onto prod after #60 lands.

Validation

  • pytest -q --confcutdir=tests/fast/rollout tests/fast/rollout/test_dynamic_sampling_filters.py (20 passed)
  • Black and Ruff on both changed files
  • py_compile
  • git diff --check

@nightlessbaron
nightlessbaron marked this pull request as ready for review August 28, 2026 17:18
@nightlessbaron
nightlessbaron requested a review from a team August 28, 2026 17:18
@flukeskywalker
flukeskywalker enabled auto-merge (squash) September 8, 2026 22:29
@flukeskywalker
flukeskywalker enabled auto-merge (rebase) September 8, 2026 22:31
auto-merge was automatically disabled September 8, 2026 22:31

Rebase failed

@flukeskywalker
flukeskywalker merged commit 34fbfcb into prod Sep 8, 2026
4 checks passed
@flukeskywalker
flukeskywalker deleted the agent/filter-zero-variance-groups branch September 8, 2026 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants