Repository navigation
iOS: a controller with no gyroscope leaves the phone's gyro in charge (#971) - #1365
Merged
Merged
Conversation
4 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix or feature
What and why
Fixes #971 (rebases and renumbers #975 onto
mainafter #1281 and #1361).Problem. On iOS, a controller that advertises a gyroscope it does not have (such as the GameSir X5 Lite) sends constant non-zero motion reports and suppresses the phone's built-in gyro.
Cause.
dm_motion_attachtreated any report that was not all zeroes as live motion.Change. Carry @Haseenesss's two patches from #975 renumbered to
0057(forwarded seedds/nxnative#1877) and0058(fork-onlytest priming update) so a controller becomes a motion source only afterrotationRatechanges from its first report.Checks and patch details
patches/0057-motion-a-controller-is-a-source-once-its-rotatio.patch(Upstream-Status: forwarded seedds/nxnative#1877)patches/0058-test-native-controller-motion-primes-the-adapter.patch(Upstream-Status: fork-only)python3 tools/engine.py checkpassed (55 patches apply cleanly to94a0944755da)git am -3of all 55 patches onto94a0944755dapassedpython3 -m unittest discover tools/testspassed (266 tests, 35 skipped, 0 failures)git diff --checkpassedChecked
python3 tools/engine.py check, zero-historygit am -3, andpython3 -m unittest discover tools/tests(266 tests, 35 skipped)dm/host/tests/t_motion_apple.manddm/host/tests/t_controllers_mac.m(delegated to GitHub Actions macOS CI)Screenshots
None, no visible change.
Scope
dm/,scripts/,docs/,ref/) is added to the repository: a change there is a patch inpatches/(a commit inengine/, thentools/engine.py export, andtools/engine.py checkpasses), with itsUpstream-Statusforwarded seedds/nxnative#..., orpendinguntil that PR is open