Skip to content

Use the PermissionFlow fork build that doesn't crash opening Settings - #2

Merged
LPFchan merged 2 commits into
mainfrom
pt/permissionflow-fix
Sep 26, 2026
Merged

LPFchan merged 2 commits into
mainfrom
pt/permissionflow-fix

Conversation

@LPFchan

@LPFchan LPFchan commented Sep 26, 2026

Copy link
Copy Markdown
Owner

Moves the PermissionFlow fork pin to 2.11.2-swift6.1.1. Built with Xcode 16's SDK, the previous build's SettingsNavigator completion inherited main-actor isolation and trapped when NSWorkspace called it off the main thread; Threek crashed on this every time it opened System Settings. Aware opens Settings the same way after the camera-denied alert.

Checks: resolved and built the Aware scheme (Debug) on Xcode 16.3.

timestamp: 2026-09-26 18-31-33 KST
changes:
- pin PermissionFlow to the fork's 2.11.2-swift6.1.1 (openApplication completion marked @sendable); AGENTS.md note updated
rationale:
- under Xcode 16.x's SDK the old build's SettingsNavigator completion inherited main-actor isolation and trapped when NSWorkspace called it off the main thread; Threek crashed on it every time it opened System Settings, and Aware's denied-camera path opens Settings the same way
checks:
- resolved the new tag and built the Aware scheme (Debug) on Xcode 16.3

project: aware
agent: claude-code
role: worker
commit: LOG-20260926-183133-decode
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-26T11:30:26.927962Z 5ab9b67 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d87ccd8456

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread AGENTS.md Outdated
@LPFchan

LPFchan commented Sep 26, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d87ccd8456

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread AGENTS.md Outdated
timestamp: 2026-09-26 20-27-59 KST
changes:
- AGENTS.md: the fork note records both changes (tools-version 6.1 and the @sendable openApplication completion) and when they can be dropped
rationale:
- Codex review on #2: a future fork-tag refresh that only carried the tools-version change would bring the Settings crash back
checks:
- docs only; Package.resolved regenerated from scratch produced the same originHash, so it was already current

project: aware
agent: claude-code
role: worker
commit: LOG-20260926-202759-decode
@LPFchan

LPFchan commented Sep 26, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: 5ab9b674de

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@LPFchan
LPFchan merged commit ba5c3dc into main Sep 26, 2026
1 check passed
@LPFchan
LPFchan deleted the pt/permissionflow-fix branch September 26, 2026 11:34
LPFchan added a commit that referenced this pull request Sep 26, 2026
timestamp: 2026-09-26 21-04-23 KST
changes:
- append "Code Review Rules" section to AGENTS.md from repo-template 1.1.9
rationale:
- the GitHub review bot repeatedly reported commits as missing provenance fields when the exact messages on GitHub contained them (Threek #11, Threek #13, Aware #2)
checks:
- section matches repo-template scaffold/AGENTS.md verbatim

project: Aware
agent: codex
role: orchestrator
commit: LOG-20260926-210423-codex
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant