Repository navigation
Build the release as a universal binary on the arm64 runner - #17
Merged
Merged
Conversation
timestamp: 2026-09-27 03-59-24 KST changes: - scripts/build-app.sh: pass ARCHS="arm64 x86_64" ONLY_ACTIVE_ARCH=NO to the release xcodebuild invocation rationale: - The release workflow now runs on macos-26, which is arm64-only; without explicit ARCHS the tagged DMGs would ship an arm64-only app and stop launching on Intel Macs checks: - local Release build with the same flags produces a universal binary (lipo reports x86_64 arm64) project: threek agent: codex role: worker commit: LOG-20260927-035924-codex
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
ARCHS="arm64 x86_64" ONLY_ACTIVE_ARCH=NOto the release build inscripts/build-app.sh.Follow-up to #16: the release workflow now runs on
macos-26, which is arm64-only. Without an explicit ARCHS override, tagged DMGs would ship an arm64-only app and stop launching on Intel Macs — the same issue Codex flagged on LPFchan/Aware#3.Validation
Local Release build with the same flags produces a universal binary (
lipo -archsreportsx86_64 arm64).