Repository navigation
fix(api): conceal hash fields on read (GHSA-mvv8-v4jj-g47j) - #427
Open
louisdussarps wants to merge 3 commits into
Open
louisdussarps wants to merge 3 commits into
louisdussarps wants to merge 3 commits into
Conversation
Hash fields without the conceal special had their submitted value stored in clear text in revisions on item creation, and their hash returned by the API. They are now concealed on read, like conceal fields. Signed-off-by: louis <louis@webcapsule.io>
Signed-off-by: louis <louis@webcapsule.io>
sofiachakir
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change description
The
hashtransformer ofPayloadServicenow conceals values on read (**********), like theconcealspecial. Empty values are left as is.Hash fields created from the data model only get the
hashspecial, withoutconceal. On item creation, the revision is built withprepareDeltafrom the payload before it is hashed, andprocessValues('read')returned the value unchanged: the submitted value was stored in clear text indirectus_revisions. Their argon2 hash was also returned by the API and stored in update snapshots. System hash fields (directus_users.password,directus_shares.password) already hadconcealand are unaffected.Authentication and share login read the stored hash directly with knex, so they are unaffected.
The flow logs part of the advisory (raw trigger payload stored in
directus_revisions) will be handled in a separate PR.Type of change
Related issues
Checklists
Development
Security
Network
Code review
necessary