Repository navigation
Conversation
With the sidebar open, every newly opened page showed all sidebar sections collapsed: sidebar-detail-group only opened the first section in a watcher on sidebarOpen changes, and each page mounts a new private-view while sidebarOpen (persisted) is already true. Also open it on mount, without the expand animation (new `disabled` prop on transition-expand), so the first section (usually "Information") is simply shown open. Opening the sidebar by hand keeps the animation. Discussion: LaWebcapsule#431 Signed-off-by: Kyrylo Kuzmytskyi <slykirill@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change description
Part of discussion #431 (item 2.3).
When the sidebar is open, it automatically expands its first section (usually "Information"). But after navigating to another page, the sidebar stays open with every section collapsed, so it shows nothing useful until the user clicks a section.
Cause:
sidebar-detail-group.vueonly opens the first section in a watcher onsidebarOpenchanges. Each page mounts a newprivate-viewwhilesidebarOpen(persisted in local storage) is alreadytrue, so the watcher never fires.Fix:
disabledprop ontransition-expandswitches the transition off: no CSS classes, no JS hooks.Type of change
Related issues
Checklists
Development
Security
Network
Code review
necessary