Skip to content

Bound the arrival acquisition type lookup to one row #1200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labkey-martyp merged 1 commit into from
Sep 11, 2026
Merged

Bound the arrival acquisition type lookup to one row #1200

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ehr/src/org/labkey/ehr/utils/TriggerScriptHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
import org.labkey.api.data.SQLFragment;
import org.labkey.api.data.Selector;
import org.labkey.api.data.SimpleFilter;
import org.labkey.api.data.Sort;
import org.labkey.api.data.SqlExecutor;
import org.labkey.api.data.SqlSelector;
import org.labkey.api.data.Table;
Expand Down Expand Up @@ -1781,7 +1782,9 @@ public void updateStatusField(List<String> ids, Map<String, List<Date>> liveBirt
ColumnInfo acquisitionColumn = columns.get(acquisitionFieldKey);
if (acquisitionColumn != null)
{
TableSelector ts = new TableSelector(arrivalTable, Collections.singleton(acquisitionColumn), new SimpleFilter(FieldKey.fromParts("Id"), id), null);
// In some cases, an animal can arrive more than once, so bound this to one row: unbounded, getObject()
// throws on the extra rows rather than picking one. Sort so the row picked is the latest arrival, not arbitrary.
TableSelector ts = new TableSelector(arrivalTable, Collections.singleton(acquisitionColumn), new SimpleFilter(FieldKey.fromParts("Id"), id), new Sort("-date")).setMaxRows(1);
acquitype = ts.getObject(String.class);
}
}
Expand Down