GH Issue 1485: Fix Show Record History dataset filter - #1201
Merged
labkey-martyp merged 1 commit intoSep 10, 2026
Conversation
The intkey1 legacy alias was removed along with the audit union table, so the dataset filter was silently dropped; datasetId is the current column. Also drops the Detailed view name, which no longer exists.
labkey-martyp
requested review from
RameshRapa,
ankurjuneja and
labkey-bpatel
September 10, 2026 12:37
labkey-bpatel
approved these changes
Sep 10, 2026
labkey-martyp
commented
Sep 10, 2026
labkey-martyp
left a comment
labkey-martyp
left a comment
Contributor
Author
There was a problem hiding this comment.
No new test failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Fixes the "Show Record History" button on EHR dataset grids, which showed a record's history from every dataset instead of filtering to the one being viewed. The button built its audit log URL with
query.intkey1~eq, a legacy column alias onauditLog.DatasetAuditEventthat was gated behind an off-by-default feature flag in 25.9 and removed outright in 26.1 along with the audit union table. The filter was therefore discarded at render time with an "Ignoring filter/sort on column 'intkey1'" warning;datasetIdis the current column.Reported in https://github.com/LabKey/internal-issues/issues/1485.
Related Pull Requests
None.
Changes