Show the full housing location and add a morning health room flag - #41
Open
labkey-martyp wants to merge 2 commits into
Open
Show the full housing location and add a morning health room flag#41labkey-martyp wants to merge 2 commits into
labkey-martyp wants to merge 2 commits into
Conversation
housing.cage holds the room-qualified location key, so the history data source and snapshot panel now read it directly instead of traversing to the cage lookup, which dropped the room. Also provisions a morningHealth flag on rooms and makes the housing reason optional.
Houses a dedicated animal against a cage location and asserts Animal Details reports the full location rather than the bare cage name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Housing history and the animal snapshot panel were displaying only the bare cage, losing the room that qualifies it, so two animals in identically-named cages in different rooms were indistinguishable. This also provisions a morning health flag on rooms so the rooms included in morning health checks can be maintained as lookup data, and drops the requirement that a housing reason be supplied.
Related Pull Requests
None.
Changes