Skip to content

Make Excel multi-tab metric compatible with PG <= 15#7832

Merged
labkey-jeckels merged 2 commits into
release26.7-SNAPSHOTfrom
26.7_fb_pg14_mutlitabMetric
Jul 10, 2026
Merged

Make Excel multi-tab metric compatible with PG <= 15#7832
labkey-jeckels merged 2 commits into
release26.7-SNAPSHOTfrom
26.7_fb_pg14_mutlitabMetric

Conversation

@labkey-jeckels

@labkey-jeckels labkey-jeckels commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Rationale

The Excel multi-tab metric uses a subquery without an alias which isn't supported until Postgres 16+

Changes

  • Add an alias

Tasks 📍

  • Claude Code Review
  • Manual Testing
  • Test Automation

@labkey-jeckels labkey-jeckels requested review from a team and labkey-susanh July 10, 2026 00:38
@labkey-jeckels labkey-jeckels self-assigned this Jul 10, 2026
@labkey-jeckels

Copy link
Copy Markdown
Contributor Author
 ERROR Table                    2026-07-09T17:23:32,534             UpgradeCheck : SQL  [30510]
      SELECT COUNT(*) FROM (SELECT *
                            FROM (SELECT COUNT(*) as count, DATE_TRUNC('second', Created) as created, Cre
                                  FROM (SELECT * FROM "audit"."c3d11_queryauditdomain" x
      WHERE (1 = 1)) t
                                  WHERE comment = 'Exported to Excel'
                                  AND CreatedBy IS NOT NULL
                                  GROUP BY CreatedBy, DATE_TRUNC('second', created)
                                  ) AS subquery
                            WHERE subquery.count > 1)

  ERROR ExceptionUtil            2026-07-09T17:23:32,626             UpgradeCheck : Exception detected anh error code Y9J6AP
  Additional exception info:
  org.springframework.jdbc.BadSqlGrammarException: ExecutingSelector; bad SQL grammar []
  DialectSQL=SELECT COUNT(*) FROM (SELECT *
                        FROM (SELECT COUNT(*) as count, DATE_TRUNC('second', Created) as created, Created
                              FROM (SELECT * FROM "audit"."c3d11_queryauditdomain" x
  WHERE (1 = 1)) t
                              WHERE comment = 'Exported to Excel'
                              AND CreatedBy IS NOT NULL
                              GROUP BY CreatedBy, DATE_TRUNC('second', created)
                              ) AS subquery
                        WHERE subquery.count > 1)
  org.springframework.jdbc.BadSqlGrammarException: ExecutingSelector; bad SQL grammar []
      at org.springframework.jdbc.support.SQLErrorCodeSQLExceptionTranslator.doTranslate(SQLErrorCodeSQLExceptionTranslator.java:244)
      at org.springframework.jdbc.support.AbstractFallbackSQLExceptionTranslator.translate(AbstractFallbaava:102)
      at org.labkey.api.data.ExceptionFramework$1.translate(ExceptionFramework.java:43)
      at org.labkey.api.data.SqlExecutingSelector$ExecutingResultSetFactory.handleSqlException(SqlExecuti
      at org.labkey.api.data.SqlExecutingSelector$ExecutingResultSetFactory.handleResultSet(SqlExecutingSelector.java:469)
      at org.labkey.api.data.BaseSelector.getObject(BaseSelector.java:355)
      at org.labkey.api.data.BaseSelector.getObject(BaseSelector.java:178)
      at org.labkey.query.persist.QueryManager.getExportTypeCountsMetric(QueryManager.java:1130)
      at org.labkey.query.persist.QueryManager.lambda$registerUsageMetrics$0(QueryManager.java:1082)
      at org.labkey.core.admin.usageMetrics.UsageMetricsServiceImpl.lambda$getModuleUsageMetrics$2(UsageM
      at java.base/java.lang.Iterable.forEach(Iterable.java:75)
      at org.labkey.core.admin.usageMetrics.UsageMetricsServiceImpl.lambda$getModuleUsageMetrics$0(UsageM
      at java.base/java.util.Map.forEach(Map.java:733)
      at org.labkey.core.admin.usageMetrics.UsageMetricsServiceImpl.getModuleUsageMetrics(UsageMetricsSer
      at org.labkey.api.util.UsageReportingLevel.putModulesMetrics(UsageReportingLevel.java:304)
      at org.labkey.api.util.UsageReportingLevel$2.addExtraParams(UsageReportingLevel.java:121)
      at org.labkey.api.util.UsageReportingLevel.generateReport(UsageReportingLevel.java:216)
      at org.labkey.api.util.UsageReportingLevel$UsageTimerTask.run(UsageReportingLevel.java:263)
      at java.base/java.util.TimerThread.mainLoop(Timer.java:572)
      at java.base/java.util.TimerThread.run(Timer.java:522)

@labkey-jeckels labkey-jeckels merged commit 7042900 into release26.7-SNAPSHOT Jul 10, 2026
8 checks passed
@labkey-jeckels labkey-jeckels deleted the 26.7_fb_pg14_mutlitabMetric branch July 10, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants