-
Notifications
You must be signed in to change notification settings - Fork 9
Remove duplicate test code - Navigation helpers #3092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
e7aac2a
Add BaseAppTest
labkey-tchad bc7497b
Centralize `buildAppURL`
labkey-tchad 41786ff
Merge remote-tracking branch 'origin/develop' into fb_appAdminPages
labkey-tchad 614111a
Fix `buildAppURL` params
labkey-tchad e832613
Remove PR template
labkey-tchad 3f43f9c
Merge remote-tracking branch 'origin/develop' into fb_appAdminPages
labkey-tchad 573bce0
Fix 'buildAppURL'
labkey-tchad 77c6cab
Merge remote-tracking branch 'origin/develop' into fb_appAdminPages
labkey-tchad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,26 @@ | ||
| package org.labkey.test.tests; | ||
|
|
||
| import org.jetbrains.annotations.Contract; | ||
| import org.labkey.test.BaseWebDriverTest; | ||
| import org.labkey.test.WebTestHelper; | ||
|
|
||
| import java.util.Map; | ||
|
|
||
| public abstract class BaseAppTest extends BaseWebDriverTest | ||
| { | ||
| @Contract(pure = true) | ||
| public abstract String getAppControllerName(); | ||
|
|
||
| @Contract(pure = true) | ||
| public String buildAppURL(String containerPath, Object... parts) | ||
| { | ||
| return WebTestHelper.buildAppURL(containerPath, getAppControllerName(), parts); | ||
| } | ||
|
|
||
| @Contract(pure = true) | ||
| public String buildAppURL(String containerPath, Map<String, ?> params, Object... parts) | ||
| { | ||
| return WebTestHelper.buildAppURL(containerPath, getAppControllerName(), params, parts); | ||
| } | ||
|
|
||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this just an assert?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Effectively, I suppose, but not conceptually.
Assertions generally reference aspects of the software under test. This is validating a parameter defined within test code.