Repository navigation
[fix] Refresh webhook signatures on every delivery attempt #1694
Description
Labels: bug, backend, points: 150
File/location: backend/src/services/webhook.service.ts:243
Description:
The timestamp and HMAC are computed before the retry loop. With delays of 1 minute then 5 minutes, the third delivery is already older than the verifier's 300-second replay window and a compliant receiver rejects all later retries.
Acceptance Criteria:
- Recompute the timestamp and HMAC immediately before each HTTP attempt while preserving the logical delivery ID.
- With fake time covering all five retry delays, verify each attempt using the default 300-second tolerance.
Notes:
Executed the real delivery function with fake time: signature ages were 0, 60, 360, 1260 and 4860 seconds.
Audited commit: 649b6976a100fd964ce191428eef1faeb50aaa39. Closest prior issues reviewed: #1189. This report concerns the specific failure or uncovered test paths described above, rather than repeating the original feature request.
Activity
Dev-dave01 commentedon Oct 21, 2026
@Dev-dave01 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @Dev-dave01 to this issue.
0takuc0mrade commentedon Oct 21, 2026
@0takuc0mrade has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @0takuc0mrade to this issue.
cythecode commentedon Oct 21, 2026
@cythecode has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @cythecode to this issue.
drips-wave commentedon Oct 21, 2026
Congratulations, @0takuc0mrade! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.
🧑💻 @0takuc0mrade: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.
Warning
When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.
🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.
🌊 Happy Wave 🌊
drips-wave commentedon Oct 21, 2026
This issue has been completed by @0takuc0mrade as part of the Stellar Wave Program's 10th Wave 🥳
😎 @0takuc0mrade: You earned 200 Points for completing this issue! Once the Wave's rewards are finalized, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.
🧑💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.
grantfox-oss commentedon Oct 21, 2026
🎉 This issue has been marked as completed on GrantFox!
@0takuc0mrade's PR #1715 was approved and merged by @blurbeast.
🏆 @0takuc0mrade: You earned 35 FoxPoints for this contribution! Your current tier: Explorer (920 total points). Track your full progress on GrantFox.
👏 Great work, @0takuc0mrade! Keep contributing to LabsCrypt.