Skip to content

fix: associate dashboard settings form labels with inputs - #1603

Open
boluxx123 wants to merge 1 commit into
LabsCrypt:mainfrom
boluxx123:fix/issue-632-frontend-dashboard-settings-tab-form-bare
Open

boluxx123 wants to merge 1 commit into
LabsCrypt:mainfrom
boluxx123:fix/issue-632-frontend-dashboard-settings-tab-form-bare

Conversation

@boluxx123

Copy link
Copy Markdown

Overview

This PR fixes an accessibility issue in the dashboard settings tab stream-creation form, where inputs were wrapped in <label> tags without id/htmlFor associations. Every control now has a stable id, and labels are consistently associated so assistive tech can reliably connect them. No visual changes.

Related Issue

Changes

♿ Form Label Association

  • [MODIFY] frontend/src/components/dashboard/dashboard-view.tsx
    • Added id attributes to every input/textarea/select in the stream-creation form (Template name, Recipient Address, Token, Total Amount, Starts At, Ends At, Cadence (seconds), and Note).
    • Standardized on the wrapping <label> pattern already used in the form, so each label is programmatically tied to its control via htmlFor + matching id.
    • Replaced the bare aria-label="Template name" input with a properly associated visible label, keeping the same markup structure and styling.

Verification Results

npm run lint
✅ passed

npm run build
✅ passed
Acceptance Criteria Status
Every input/textarea/select in this form has an id ✅ All controls in the stream-creation form now carry unique ids
Labels are consistently associated across the form ✅ Wrapping <label> pattern applied uniformly with htmlFor matching each control id
No visual change; lint + CI green ✅ Markup-only change; lint and build pass

Closes #632

@boluxx123
boluxx123 force-pushed the fix/issue-632-frontend-dashboard-settings-tab-form-bare branch from 6c4b696 to f4a8698 Compare October 1, 2026 11:43
@boluxx123
boluxx123 force-pushed the fix/issue-632-frontend-dashboard-settings-tab-form-bare branch from f4a8698 to 1539caa Compare October 21, 2026 21:00

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Frontend] Dashboard settings tab form: bare-string labels with no htmlFor association

2 participants