Repository navigation
Conversation
…related-issues-1505-1510-1550-1551
boluxx123
force-pushed
the
fix/duplicate-indexer-dead-letter-model
branch
from
October 4, 2026 07:53
cee6e0d to
f4a8698
Compare
boluxx123
force-pushed
the
fix/duplicate-indexer-dead-letter-model
branch
from
October 21, 2026 21:00
f4a8698 to
1539caa
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
backend/prisma/schema.prismadeclaresmodel IndexerDeadLetterEventtwice (lines 71 and 164), so every Prisma command fails before anything else runs:This breaks
prisma migrate/generate, the backend build and theEphemeral full-stack previewjob.It is a botched merge: two branches added a dead-letter feature and both copies survived. The definitions are incompatible — one uses
ledger/transactionHash/rawPayload, the othereventType/txHash/ledgerSequence/cursor/payload. The second is the one the code and ADR 0003 use (indexerService.quarantineEvent, the admin dead-letter API and its tests).Fix — resolve on the ADR-aligned shape
IndexerDeadLetterEventblock fromschema.prisma;20260830000000_add_indexer_dead_letter_event(itsCREATE TABLEmatches that first shape; the newer20260926000000_...migration already creates the final table);deadLetterEvent()method — the only remaining consumer of the first shape. It has not been called since the merge: the poll loop quarantines viaquarantineEvent(event, err)(shape B). ItsdeadLetterMaxRetriesfield,DEAD_LETTER_MAX_RETRIES_DEFAULTconstant andINDEXER_DEAD_LETTER_MAX_RETRIESread go with it, since the live path never consulted the cap.No behaviour change — the executed quarantine path is untouched.
Verification (local)
TypeScript parses cleanly after the removal.