Repository navigation
Conversation
Add filter pill buttons (All, Created, Withdrawn, Topped Up, Paused, Cancelled) at the top of ActivityHistory to filter displayed stream lifecycle events client-side and render the empty state message when no events match the active filter. Fixes LabsCrypt#1641
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds client-side event type filter pills (
All,Created,Withdrawn,Topped Up,Paused,Cancelled) at the top ofActivityHistory(frontend/src/components/dashboard/ActivityHistory.tsx) so users can filter the activity timeline by stream lifecycle event type.Type of Change
Related Issues
Closes #1641
Fixes #1641
/claim #1641
Changes Made
ACTIVITY_FILTER_OPTIONS(All,Created,Withdrawn,Topped Up,Paused,Cancelled) andActivityEventFilterinfrontend/src/components/dashboard/ActivityHistory.tsx."ALL"and rendered accessible filter pill buttons (role="group",aria-label="Filter activity by event type",aria-pressed) alongside theExport CSVcontrol.selectedFilter, displaying the empty state message ("No activity found for this filter.") when no events match.frontend/src/components/dashboard/ActivityHistory.test.tsxverifying default"All"selection, immediate filtering across event types, and empty state rendering when no events match.Testing
Test Coverage
Test Steps
npx vitest run src/components/dashboard/ActivityHistory.test.tsx src/__tests__/a11y.test.tsxinfrontend/(14/14 tests pass).npx tsc --noEmitinfrontend/(0 errors).npx eslint src/components/dashboard/ActivityHistory.tsx src/components/dashboard/ActivityHistory.test.tsxinfrontend/(0 errors).Checklist
Additional Notes
Payout Details
0x9a51790aC01c54184bcFa067bC38f7F0E7C6F6B6