Repository navigation
fix(api,export): resolve stream statuses, accept full-width IDs, inde… - #1720
Merged
blurbeast merged 1 commit intoOct 22, 2026
Merged
Conversation
…x protocol fees, and terminate streaming errors Closes LabsCrypt#1698 Closes LabsCrypt#1699 Closes LabsCrypt#1700 Closes LabsCrypt#1701
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses four assigned backend issues in GraphQL stream filtering, full-width identifier parsing, accounting export fee accuracy, and streaming error lifecycle termination:
Type of Change
Related Issues
Closes #1698
Closes #1699
Closes #1700
Closes #1701
Changes Made
backend/src/graphql/resolvers/stream.resolver.ts:filter.statusdistinctly across'active','paused','cancelled', and'completed'states rather than evaluating status against a single booleanisActive.resolveStreamto safely handle Soroban u64 stream identifiers.backend/src/graphql/schema.ts:streamIdargument types inQuery.streamandSubscription.streamUpdatedfrom 32-bitintArg()to losslessstringArg().backend/src/services/export.service.ts:calculateProtocolFee.getProtocolFeeForEventto derive actual protocol fees from indexedFEE_COLLECTEDevents and transaction metadata.res.destroy(error)withres.end()fallback) in bothstreamTransactionCSVandstreamTransactionJSONcatch blocks when errors occur after headers are sent.backend/tests/graphql.test.ts:backend/tests/export.service.test.ts:Testing
Test Coverage
Test Steps
npm test -- tests/graphql.test.ts tests/export.service.test.ts