Skip to content

[test] useToastStore has no dedicated test; duration defaults, truncation, and update-recompute logic are unverified #1900

Description

@K1NGD4VID

File/location: frontend/src/app/stores/useToastStore.ts

Description:
No dedicated test file exists for useToastStore.ts, and it is not covered by stores/stores.test.ts (which tests useUserStore, useWalletStore, useUIStore, useThemeStore, useGamificationStore but not useToastStore). Untested logic includes withDefaultDuration's error-vs-default duration selection, the MAX_STORED_TOASTS=20 truncation via .slice(0, MAX_STORED_TOASTS), and updateToast's 'recompute duration when type changes but no explicit duration is given' branch. It is only exercised indirectly through useContractMutation.test.tsx for a few specific flows.

Acceptance Criteria:

  • Dedicated test file covers: default duration selection by toast type, MAX_STORED_TOASTS truncation behavior, and updateToast's duration-recompute-on-type-change branch

Filed via automated codebase sweep (frontend / test).

Activity

  1. added
    frontendIssues related to frontend development
    testingAdding or fixing tests
    on Sep 27, 2026
  2. shobhamerabacha-star commented on Sep 27, 2026

    @shobhamerabacha-star

    Hello @maintainers,

    I would love to take this on. My planned approach:

    • Implement robust automated tests covering [test] useToastStore has no dedicated test; duration defaults, truncation, and update-recompute logic are unverified with clean isolation and assertion checks.
    • Verify all test cases pass locally and in the GitHub Actions CI workflow.

    I am ready to start immediately—please feel free to assign this to me!

  3. Simultech369 commented on Sep 28, 2026

    @Simultech369

    Hello Maintainers!

    Autonomous Council implementation and test verification for this issue has been completed, passing all test suites across 5 review surfaces, and submitted in PR #1908 (#1908).

    Stellar Wave 9 Formalization & 1-Click Acceptance:

    Maintainer Action: To credit this work for Wave 9 on Drips, please assign @Simultech369 to this issue or review and accept via the Drips Maintainer Portal:
    Review / Accept on Drips Maintainer Dashboard

    Thank you for your review!

  4. Wittig18 commented on Oct 18, 2026

    @Wittig18

    @Wittig18 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    hey maintainer, i would love to work on this

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Wittig18 to this issue.

  5. EmmanuelOchaje commented on Oct 18, 2026

    @EmmanuelOchaje
    Contributor

    @EmmanuelOchaje has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    hi there let me fix this

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @EmmanuelOchaje to this issue.

  6. CollinsKRO commented on Oct 18, 2026

    @CollinsKRO

    @CollinsKRO has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hi Maintainer, I can fix this pls assign. ETA 5hrs

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @CollinsKRO to this issue.

  7. drips-wave commented on Oct 18, 2026

    @drips-wave

    Congratulations, @EmmanuelOchaje! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.

    🧑‍💻 @EmmanuelOchaje: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

    Warning

    When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

    🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

    🌊 Happy Wave 🌊

  8. grantfox-oss commented on Oct 18, 2026

    @grantfox-oss

    🎉 This issue has been marked as completed on GrantFox!

    @EmmanuelOchaje's PR #2031 was approved and merged by @blurbeast.

    🏆 @EmmanuelOchaje: You earned 35 FoxPoints for this contribution! Your current tier: Explorer (646 total points). Track your full progress on GrantFox.

    👏 Great work, @EmmanuelOchaje! Keep contributing to LabsCrypt.

  9. drips-wave commented on Oct 18, 2026

    @drips-wave

    This issue has been completed by @EmmanuelOchaje as part of the Stellar Wave Program's 10th Wave 🥳

    😎 @EmmanuelOchaje: You earned 200 Points for completing this issue! Once the Wave's rewards are finalized, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

    🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Stellar WaveIssues in the Stellar wave programfrontendIssues related to frontend developmenttestingAdding or fixing tests

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions