Skip to content

[Documentation] docs/webhooks.md documents non-existent '/api/webhooks/subscriptions' endpoints and outdated payload schema #2030

Closed

Description

@blurbeast

Issue #150

docs/webhooks.md Documents Non-Existent '/api/webhooks/subscriptions' Endpoints and Outdated Payload Schema

  • Title: [Documentation] docs/webhooks.md documents non-existent '/api/webhooks/subscriptions' endpoints and outdated payload schema
  • Labels: documentation, backend, good first issue
  • Location: docs/webhooks.md:23-73, 165-271, backend/src/routes/indexerRoutes.ts:304-465, backend/src/schemas/indexerSchemas.ts:62-75, backend/src/services/webhookService.ts:15-26
  • Description:
    docs/webhooks.md is out of sync with the actual webhook implementation in the backend:
    1. It documents /api/webhooks/subscriptions endpoints instead of the actual /api/indexer/webhooks/subscribe, GET /api/indexer/webhooks, DELETE /api/indexer/webhooks/:subscriptionId, and POST /api/indexer/webhooks/:subscriptionId/replay-dlq routes.
    2. It documents { url, events, description } instead of webhookSubscribeSchema's { callbackUrl, eventTypes, secret }.
    3. It documents a nested { event, id, timestamp, data } payload and 10s/8-attempt retry config instead of the flat WebhookPayload structure and 30s/5-attempt config in webhookService.ts.
  • Impact:
    External integrators following docs/webhooks.md hit 404 Not Found on every webhook management endpoint, 400 Validation Error on subscription creation, and fail to parse incoming webhook payloads.
  • Suggested Fix:
    Update docs/webhooks.md to document the actual /api/indexer/webhooks/* endpoints, the { callbackUrl, eventTypes, secret } request schema, the flat WebhookPayload delivery structure, and the actual retry/timeout constants from backend/src/services/webhookService.ts.

Activity

  1. added
    documentationImprovements or additions to documentation
    backendIssues related to backend development
    on Oct 18, 2026
  2. ranjeetprabhatedu-dotcom commented on Oct 18, 2026

    @ranjeetprabhatedu-dotcom

    Hello maintainers,

    I reviewed "[Documentation] docs/webhooks.md documents non-existent '/api/webhooks/subscriptions' endpoints and outdated payload schema" and would like to work on this.

    I have reviewed the problem description and acceptance criteria for this issue. I have a clear, tested implementation ready with defensive error handling and 100% green CI proof.

    I will deliver a clean, well-tested, and production-ready PR promptly upon assignment. Kindly assign this issue to me.

    Thank you!

  3. harmondconsultant-png commented on Oct 18, 2026

    @harmondconsultant-png

    @harmondconsultant-png has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    hy, i can work on it pleas assign

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @harmondconsultant-png to this issue.

  4. bade2brazy commented on Oct 18, 2026

    @bade2brazy
    Contributor

    @bade2brazy has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    assign this issue to me

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @bade2brazy to this issue.

  5. cyberdocs120 commented on Oct 18, 2026

    @cyberdocs120

    @cyberdocs120 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    I'd like to take this issue. It covers an important part of the project, and I want to contribute something that fits the existing architecture and development standards and holds up over time.

    I've worked across backend and frontend development, APIs, databases, testing, DevOps, and blockchain-based applications. I'm comfortable reading an unfamiliar codebase, tracking an issue down to its root cause, and writing clean fixes with tests that guard against regressions.

    My plan is to start by reading the existing implementation and project conventions, then build the solution in small, focused steps. I'll test the changes, document them where needed, and keep the code simple so nothing existing breaks. I'll also respond quickly to review feedback so the PR is easy to merge.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @cyberdocs120 to this issue.

  6. drips-wave commented on Oct 18, 2026

    @drips-wave

    Congratulations, @bade2brazy! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.

    🧑‍💻 @bade2brazy: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

    Warning

    When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

    🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

    🌊 Happy Wave 🌊

  7. bade2brazy commented on Oct 18, 2026

    @bade2brazy
    Contributor

    Resolved in PR #2032. Updated docs/webhooks.md to document actual /api/indexer/webhooks routes, { callbackUrl, eventTypes, secret } schema, flat IndexedLoanEvent payload examples, and 30s/4-attempt retry semantics.

  8. drips-wave commented on Oct 18, 2026

    @drips-wave

    This issue has been completed by @bade2brazy as part of the Stellar Wave Program's 10th Wave 🥳

    😎 @bade2brazy: You earned 200 Points for completing this issue! Once the Wave's rewards are finalized, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

    🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Stellar WaveIssues in the Stellar wave programbackendIssues related to backend developmentdocumentationImprovements or additions to documentationgood first issueGood for newcomers

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions