Repository navigation
fix: match cookie security attributes in logout clearCookie - #1965
Open
Mikardo001 wants to merge 1 commit into
Open
Mikardo001 wants to merge 1 commit into
Mikardo001 wants to merge 1 commit into
Conversation
…es-1873-1874-1875-1876
| import logger from '../utils/logger.js'; | ||
|
|
||
| const logAuthFailure = (req: Request, publicKey: string | undefined, reason: string): void => { | ||
| const logAythFailure = (req: Request, publicKey: string | undefined, reason: string): void => { |
Mikardo001
force-pushed
the
security/issue-1829-backend-authcontroller-logout-omits-cookie
branch
from
October 12, 2026 18:17
bbee2d7 to
4429eda
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes a security issue in
authController.logoutwhere the auth cookie was cleared without the security attributes used when it was set. Becauseres.clearCookiewas called with only{ path: '/' }, modern browsers could ignore the expiration directive, leaving the session cookie stored and valid after logout. The fix passes the same options used inauthController.login.Related Issue
Changes
🔒 Cookie Clearing Fix
backend/src/controllers/authController.tsauthController.logoutto callres.clearCookiewith the same options used when the cookie is set inauthController.login:{ httpOnly: true, secure: true, sameSite: 'strict', path: '/' }.Set-Cookieexpiration directive matches the original cookie's security flags so browsers reliably delete the session cookie on logout.Verification Results
clearCookieuses matching security attributeshttpOnly,secure,sameSite: 'strict', andpath: '/'now passedauthController.loginauthController.logoutmodifiedCloses #1829