Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A switch to an account whose refresh token is no longer accepted fails with
Token refresh failed: 401 Unauthorized. The only way out is to delete the account and add it again.Fix
Sign-in expired:.complete_reauthorizecommand stores the new tokens on the existing account instead of adding a new one, and then the switch runs again.AddAccountModalintoOAuthLinkPanel, so both dialogs share it.style(tray): apply rustfmtonly formatstray.rs, because the PR check runs rustfmt on every changed Rust file.The token endpoint answers a made-up refresh token with
401and{"code": "invalid_refresh_token", "message": "Could not validate your refresh token. Please try signing in again."}, so 401 is the signal for a new sign-in.Testing
cargo test, with new tests for the error classification and the same-account check.pnpm buildandpnpm test, with a new test for the error check in the UI.